Use IReadOnlyList instead of arrays for MarketChart properties

Author: Tsingis

App/Services/Extensions/ListExtensions.cs

@@ -2,7 +2,7 @@ namespace Services.Extensions;
 
 public static class ListExtensions
 {
-    public static bool IsNullOrEmpty<T>(this IList<T>? list)
+    public static bool IsNullOrEmpty<T>(this IReadOnlyList<T>? list)
     {
         return list is null || list.Count == 0;
     }

App/Services/Models/MarketChart.cs

@@ -5,9 +5,8 @@ namespace Services.Models;
 public record MarketChart
 {
     [JsonPropertyName("prices")]
-    public decimal[][]? Prices { get; init; }
-    [JsonPropertyName("market_caps")]
-    public decimal[][]? MarketCaps { get; init; }
+    public IReadOnlyList<IReadOnlyList<decimal>>? Prices { get; init; }
+    [JsonPropertyName("market_caps")] public IReadOnlyList<IReadOnlyList<decimal>>? MarketCaps { get; init; }
     [JsonPropertyName("total_volumes")]
-    public decimal[][]? TotalVolumes { get; init; }
+    public IReadOnlyList<IReadOnlyList<decimal>>? TotalVolumes { get; init; }
 }

App/Services/Utility/MarketChartHelper.cs

@@ -22,14 +22,14 @@ public static List<MarketChartPoint> MapMarketChartToMarketChartPoints(MarketCha
             throw new MarketChartException($"{nameof(marketChart.TotalVolumes)} is null");
         }
 
-        if (marketChart.Prices.Length != marketChart.MarketCaps.Length ||
-            marketChart.Prices.Length != marketChart.TotalVolumes.Length)
+        if (marketChart.Prices.Count != marketChart.MarketCaps.Count ||
+            marketChart.Prices.Count != marketChart.TotalVolumes.Count)
         {
             throw new MarketChartException("Unequal number of data points in market chart");
         }
 
         var marketChartPoints = new List<MarketChartPoint>();
-        for (var i = 0; i < marketChart.Prices.Length; i++)
+        for (var i = 0; i < marketChart.Prices.Count; i++)
         {
             var marketData = new MarketChartPoint
             {

Directory.Build.props

@@ -14,7 +14,7 @@
     <EnforeCodeStyleInBuild>true</EnforeCodeStyleInBuild>
     <EnableNETAnalyzers>true</EnableNETAnalyzers>
     <EnableCodeAnalysis>true</EnableCodeAnalysis>
-    <NoWarn>S6678;CA2007;CA1848;CA1002;CA1819;CA1305;CA1062;CA2000;CA5394;CA1724;CA1031;S3267;CA1515;S1118;CA1707;CA2234;CA1051;CA1063;S3881</NoWarn>
+    <NoWarn>S6678;CA2007;CA1848;CA1002;CA1305;CA1062;CA2000;CA5394;CA1724;CA1031;S3267;CA1515;S1118;CA1707;CA2234;CA1051;CA1063;S3881</NoWarn>
   </PropertyGroup>
   <ItemGroup Condition="'$(MSBuildProjectExtension)' != '.dcproj'">
     <PackageReference Include="SonarAnalyzer.CSharp">