Skip to content

Commit a76538a

Browse files
committed
Adjust env variable naming
1 parent 7872036 commit a76538a

File tree

7 files changed

+17
-18
lines changed

7 files changed

+17
-18
lines changed

.env.example

Lines changed: 3 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -1,11 +1,10 @@
11
ASPNETCORE_ENVIRONMENT=Development
2+
ASPNETCORE_URLS=http://localhost:8080;https://localhost:8081
23
ASPNETCORE_HTTP_PORTS=8080
34
ASPNETCORE_HTTPS_PORTS=8081
4-
ASPNETCORE_URLS=http://localhost:8080;https://localhost:8081
55
KEY_VAULT_NAME=key-vault-name
66
USE_JSON_FORMATTING=false
77
USE_OUTPUT_CACHE=true
8-
USE_MOCKING=true
9-
SHOW_MOCKING_LOGS=false
8+
USE_MOCK_SERVER=true
9+
SHOW_MOCK_SERVER_LOGS=false
1010
TESTING_LOG_LEVEL=Information
11-
MARKET_CLIENT_URL=http://localhost:9091

.github/workflows/test.yml

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -39,8 +39,8 @@ jobs:
3939
dotnet test -c Release --no-restore --no-build \
4040
--settings tests/coverage.runsettings --results-directory ${{ github.workspace }}/test-results
4141
env:
42-
USE_MOCKING: ${{ vars.USE_MOCKING }}
43-
SHOW_MOCKING_LOGS: ${{ vars.SHOW_MOCKING_LOGS }}
42+
USE_MOCK_SERVER: ${{ vars.USE_MOCK_SERVER }}
43+
SHOW_MOCK_SERVER_LOGS: ${{ vars.SHOW_MOCK_SERVER_LOGS }}
4444
TESTING_LOG_LEVEL: ${{ vars.TESTING_LOG_LEVEL }}
4545
- name: Find coverage files and generate report
4646
run: |

docker-compose.yml

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -14,8 +14,8 @@ services:
1414
KEY_VAULT_NAME: $KEY_VAULT_NAME
1515
USE_OUTPUT_CACHE: $USE_OUTPUT_CACHE
1616
USE_JSON_FORMATTING: $USE_JSON_FORMATTING
17-
USE_MOCKING: $USE_MOCKING
18-
SHOW_MOCKING_LOGS: $SHOW_MOCKING_LOGS
17+
USE_MOCK_SERVER: $USE_MOCK_SERVER
18+
SHOW_MOCK_SERVER_LOGS: $SHOW_MOCKING_LOGS
1919
MARKET_CLIENT_URL: http://wiremock:8080
2020
user: app
2121
read_only: true

src/Api/Setup/DateOnlyExampleProvider.cs

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -7,7 +7,7 @@ namespace Api.Setup;
77

88
public sealed class DateOnlyExampleProvider : IExampleProvider<DateOnly>
99
{
10-
public static DateOnly GenerateExample() => EnvVarAccessors.UseMocking ? new DateOnly(2025, 8, 30) : DateOnly.FromDateTime(DateTime.UtcNow);
10+
public static DateOnly GenerateExample() => EnvVarAccessors.UseMockServer ? new DateOnly(2025, 8, 30) : DateOnly.FromDateTime(DateTime.UtcNow);
1111
}
1212

1313
[JsonSerializable(typeof(DateOnly))]

src/Common/EnvVarsHelper.cs

Lines changed: 6 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -6,18 +6,18 @@ public static class EnvVarKeys
66
public const string UseJsonFormatting = "USE_JSON_FORMATTING";
77
public const string UseOutputCache = "USE_OUTPUT_CACHE";
88
public const string MarketClientUrl = "MARKET_CLIENT_URL";
9-
public const string UseMocking = "USE_MOCKING";
10-
public const string ShowMockingLogs = "SHOW_MOCKING_LOGS";
9+
public const string UseMockServer = "USE_MOCK_SERVER";
10+
public const string ShowMockServerLogs = "SHOW_MOCK_SERVER_LOGS";
1111
public const string TestingLogLevel = "TESTING_LOG_LEVEL";
1212
}
1313

1414
public static class EnvVarAccessors
1515
{
16-
public static bool UseMocking =>
17-
bool.TryParse(Environment.GetEnvironmentVariable(EnvVarKeys.UseMocking), out var value) && value;
16+
public static bool UseMockServer =>
17+
bool.TryParse(Environment.GetEnvironmentVariable(EnvVarKeys.UseMockServer), out var value) && value;
1818

19-
public static bool ShowMockingLogs =>
20-
bool.TryParse(Environment.GetEnvironmentVariable(EnvVarKeys.ShowMockingLogs), out var value) && value;
19+
public static bool ShowMockServerLogs =>
20+
bool.TryParse(Environment.GetEnvironmentVariable(EnvVarKeys.ShowMockServerLogs), out var value) && value;
2121

2222
public static bool UseJsonFormatting =>
2323
bool.TryParse(Environment.GetEnvironmentVariable(EnvVarKeys.UseJsonFormatting), out var value) && value;

tests/IntegrationTests/Setup/Fixture.cs

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -18,7 +18,7 @@ public Fixture()
1818
{
1919
DotNetEnv.Env.TraversePath().Load();
2020

21-
if (EnvVarAccessors.UseMocking)
21+
if (EnvVarAccessors.UseMockServer)
2222
{
2323
var image = GetImage("wiremock", Path.Join(AppContext.BaseDirectory, "docker-compose.yml"));
2424

@@ -53,7 +53,7 @@ public async ValueTask InitializeAsync()
5353
TestContext.Current.SendDiagnosticMessage("Starting Wiremock container");
5454
await _wireMockContainer.StartAsync(ct).ConfigureAwait(false);
5555

56-
if (EnvVarAccessors.ShowMockingLogs)
56+
if (EnvVarAccessors.ShowMockServerLogs)
5757
{
5858
var (Stdout, _) = await _wireMockContainer.GetLogsAsync(ct: ct).ConfigureAwait(false);
5959
TestContext.Current.SendDiagnosticMessage($"[WireMock] {Stdout}");

tests/IntegrationTests/Setup/TestApplicationFactory.cs

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -18,7 +18,7 @@ public sealed class TestApplicationFactory(Fixture fixture) : WebApplicationFact
1818
{
1919
protected override void ConfigureWebHost(IWebHostBuilder builder)
2020
{
21-
if (EnvVarAccessors.UseMocking)
21+
if (EnvVarAccessors.UseMockServer)
2222
{
2323
builder?.ConfigureAppConfiguration((context, builder) =>
2424
{

0 commit comments

Comments
 (0)