Environment variable usage improvements

Author: Tsingis

.env.example

@@ -1,6 +1,6 @@
 ASPNETCORE_ENVIRONMENT=Development
 ASPNETCORE_HTTP_PORTS=8080
 KEY_VAULT_NAME=key-vault-name
-OUTPUT_CACHE=true
+USE_OUTPUT_CACHE=true
 USE_MOCKING=true
 MARKET_CLIENT_URL=http://localhost:9091

src/Api/Program.cs

@@ -26,7 +26,7 @@
 
     var builder = WebApplication.CreateBuilder(args);
 
-    var keyVaultName = builder.Configuration.GetValue<string>(EnvironmentVariable.KeyVaultName);
+    var keyVaultName = builder.Configuration.GetValue<string>(EnvVarKeys.KeyVaultName);
     if (builder.Environment.IsProduction() && !string.IsNullOrEmpty(keyVaultName))
     {
         var keyVaultUri = new Uri($"https://{keyVaultName}.vault.azure.net/");

src/Api/Setup/ApiMiddleware.cs

@@ -1,3 +1,4 @@
+using Common;
 using Scalar.AspNetCore;
 
 namespace Api.Setup;
@@ -13,7 +14,7 @@ public static void ConfigureMiddleware(this WebApplication app, IWebHostEnvironm
 
         app.UseRouting();
 
-        if (configuration.GetValue("OUTPUT_CACHE", true))
+        if (configuration.GetValue(EnvVarKeys.UseOutputCache, true))
         {
             app.UseOutputCache();
         }

src/Common/EnvVarsHelper.cs

@@ -0,0 +1,15 @@
+namespace Common;
+
+public static class EnvVarKeys
+{
+    public const string KeyVaultName = "KEY_VAULT_NAME";
+    public const string UseOutputCache = "USE_OUTPUT_CACHE";
+    public const string MarketClientUrl = "MARKET_CLIENT_URL";
+    public const string UseMocking = "USE_MOCKING";
+}
+
+public static class EnvVarAccessors
+{
+    public static bool UseMocking =>
+        bool.TryParse(Environment.GetEnvironmentVariable(EnvVarKeys.UseMocking), out var value) && value;
+}

src/Common/EnvironmentVariable.cs

@@ -25,7 +25,7 @@ public class MarketClient(ILogger<MarketClient> logger, IConfiguration configura
 
         using (var httpClient = _httpClientFactory.CreateClient())
         {
-            httpClient.BaseAddress = new Uri(configuration.GetValue(EnvironmentVariable.MarketClientUrl, "https://api.coingecko.com"));
+            httpClient.BaseAddress = new Uri(configuration.GetValue(EnvVarKeys.MarketClientUrl, "https://api.coingecko.com"));
             var response = await httpClient.SendAsync(request).ConfigureAwait(false);
             if (response.IsSuccessStatusCode)
             {

src/Services/MarketClient.cs

@@ -8,9 +8,9 @@ public sealed class ApplicationFactory(Fixture fixture) : WebApplicationFactory<
 {
     protected override void ConfigureWebHost(IWebHostBuilder builder)
     {
-        if (bool.Parse(Environment.GetEnvironmentVariable(EnvironmentVariable.UseMocking) ?? "false"))
+        if (EnvVarAccessors.UseMocking)
         {
-            Environment.SetEnvironmentVariable(EnvironmentVariable.MarketClientUrl, $"http://localhost:{fixture.GetPort()}");
+            builder?.UseSetting(EnvVarKeys.MarketClientUrl, $"http://localhost:{fixture.GetPort()}");
         }
     }
 }

tests/IntegrationTests/Setup/ApplicationFactory.cs

@@ -17,7 +17,7 @@ public Fixture()
     {
         DotNetEnv.Env.TraversePath().Load();
 
-        if (bool.Parse(Environment.GetEnvironmentVariable(EnvironmentVariable.UseMocking) ?? "false"))
+        if (EnvVarAccessors.UseMocking)
         {
             _wireMockContainer = new ContainerBuilder()
                 .WithCleanUp(true)