Fix application insights connection string and fetching

Author: Tsingis

App/Api/Program.cs

@@ -23,16 +23,16 @@
 
     var builder = WebApplication.CreateBuilder(args);
 
-    if (builder.Environment.IsProduction())
+    var keyVaultName = Environment.GetEnvironmentVariable("KEY_VAULT_NAME");
+    if (builder.Environment.IsProduction() && !string.IsNullOrEmpty(keyVaultName))
     {
-        var keyVaultName = Environment.GetEnvironmentVariable("KEY_VAULT_NAME");
         var keyVaultUri = new Uri($"https://{keyVaultName}.vault.azure.net/");
         builder.Configuration.AddAzureKeyVault(keyVaultUri, new DefaultAzureCredential());
 
         Log.Logger = new LoggerConfiguration()
-            .ReadFrom.Configuration(config)
+            .ReadFrom.Configuration(builder.Configuration)
             .WriteTo.Console(outputTemplate: logFormat, formatProvider: CultureInfo.InvariantCulture)
-            .WriteTo.ApplicationInsights(config["ApplicationInsightsConnectionString"], TelemetryConverter.Traces)
+            .WriteTo.ApplicationInsights(builder.Configuration["ApplicationInsights:ConnectionString"], TelemetryConverter.Traces)
             .CreateLogger();
     }
 

terraform/main.tf

@@ -30,7 +30,7 @@ resource "azurerm_application_insights" "ai" {
 }
 
 resource "azurerm_key_vault_secret" "ai_connection_string" {
-  name         = "ApplicationInsightsConnectionString"
+  name         = "ApplicationInsights--ConnectionString"
   value        = azurerm_application_insights.ai.connection_string
   key_vault_id = azurerm_key_vault.kv.id
 }