Skip to content

ErrorPageApplicationWrapper without TraceErrorsMiddleware will mute tracebacks  #119

@kiilerix

Description

@kiilerix

ErrorPageApplicationWrapper will (if enabled) catch application errors and (if handle_exceptions (which is default)) store them in backlash.exc_environ and backlash.exc_info where backlash TraceErrorsMiddleware can pick it up. It will catch and store no matter if backlash.TraceErrorsMiddleware actuallly is enabled. Disabling backlash with trace_errors.enable (which users might want for other reasons) will thus effectively hide application errors. That dependency will confusingly hide errors when they happen, and doesn't seem necessary.

I suggest to effectively let errorpage.handle_exceptions default to false if not using TraceErrorsMiddleware.

(In some ways it seems like it would be better have these two middlewares come in the opposite order.)

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions