Merge branch 'master' into proz/fix-destination-coord

Author: smallsaucepan

.github/workflows/prerelease.yml

@@ -17,17 +17,17 @@ jobs:
     runs-on: ${{matrix.platform}}
 
     steps:
-      - uses: actions/checkout@v4
+      - uses: actions/checkout@11bd71901bbe5b1630ceea73d27597364c9af683 # 4.2.2
         with:
           fetch-depth: 0
 
       - name: Install pnpm
-        uses: pnpm/action-setup@v4
+        uses: pnpm/action-setup@a7487c7e89a18df4991f7f222e4898a00d66ddda # 4.1.0
         with:
           run_install: false
 
       - name: Use Node.js ${{ matrix.node-version }}
-        uses: actions/setup-node@v4
+        uses: actions/setup-node@cdca7365b2dadb8aad0a33bc7601856ffabcc48e # 4.3.0
         with:
           node-version: ${{ matrix.node-version }}
           registry-url: "https://registry.npmjs.org"

.github/workflows/release.yml

@@ -21,17 +21,17 @@ jobs:
     runs-on: ${{matrix.platform}}
 
     steps:
-      - uses: actions/checkout@v4
+      - uses: actions/checkout@11bd71901bbe5b1630ceea73d27597364c9af683 # 4.2.2
         with:
           fetch-depth: 0
 
       - name: Install pnpm
-        uses: pnpm/action-setup@v4
+        uses: pnpm/action-setup@a7487c7e89a18df4991f7f222e4898a00d66ddda # 4.1.0
         with:
           run_install: false
 
       - name: Use Node.js ${{ matrix.node-version }}
-        uses: actions/setup-node@v4
+        uses: actions/setup-node@cdca7365b2dadb8aad0a33bc7601856ffabcc48e # 4.3.0
         with:
           node-version: ${{ matrix.node-version }}
           registry-url: "https://registry.npmjs.org"
@@ -51,7 +51,7 @@ jobs:
           NODE_AUTH_TOKEN: ${{ secrets.NPM_TOKEN }}
 
       - name: Create Github Release
-        uses: softprops/action-gh-release@v2
+        uses: softprops/action-gh-release@c95fe1489396fe8a9eb87c0abf8aa5b2ef267fda # 2.2.1
         with:
           make_latest: true
           generate_release_notes: true

.github/workflows/turf.yml

@@ -23,15 +23,15 @@ jobs:
 
     steps:
       - name: Checkout
-        uses: actions/checkout@v4
+        uses: actions/checkout@11bd71901bbe5b1630ceea73d27597364c9af683 # 4.2.2
 
       - name: Install pnpm
-        uses: pnpm/action-setup@v4
+        uses: pnpm/action-setup@a7487c7e89a18df4991f7f222e4898a00d66ddda # 4.1.0
         with:
           run_install: false
 
       - name: Use Node.js ${{ matrix.node-version }}
-        uses: actions/setup-node@v4
+        uses: actions/setup-node@cdca7365b2dadb8aad0a33bc7601856ffabcc48e # 4.3.0
         with:
           cache: "pnpm"
           node-version: ${{ matrix.node-version }}

packages/turf-nearest-point-on-line/index.ts

@@ -89,11 +89,13 @@ function nearestPointOnLine<G extends LineString | MultiLineString>(
         let wasEnd: boolean;
 
         // Short circuit if snap point is start or end position of the line
-        // segment.
+        // segment or if start is equal to stop position.
         if (startPos[0] === ptPos[0] && startPos[1] === ptPos[1]) {
           [intersectPos, , wasEnd] = [startPos, undefined, false];
         } else if (stopPos[0] === ptPos[0] && stopPos[1] === ptPos[1]) {
           [intersectPos, , wasEnd] = [stopPos, undefined, true];
+        } else if (startPos[0] === stopPos[0] && startPos[1] === stopPos[1]) {
+          [intersectPos, , wasEnd] = [stopPos, undefined, true];
         } else {
           // Otherwise, find the nearest point the hard way.
           [intersectPos, , wasEnd] = nearestPointOnSegment(

packages/turf-nearest-point-on-line/test.ts

@@ -499,3 +499,21 @@ test("turf-nearest-point-on-line -- issue 965", (t) => {
   );
   t.end();
 });
+
+test("turf-nearest-point-on-line -- issue 2808 redundant point support", (t) => {
+  // include redundant points in line
+  const line1 = lineString([
+    [10.57846, 49.8463959],
+    [10.57846, 49.8468386],
+    [10.57846, 49.8468386],
+    [10.57846, 49.8468386],
+    [10.57846, 49.8472814],
+    [10.57846, 49.8472814],
+  ]);
+  const thePoint = point([10.57846, 49.8468386]);
+
+  const nearest = nearestPointOnLine(line1, thePoint); // should not throw
+  t.equal(nearest.properties.dist, 0, "redundant point should not throw");
+
+  t.end();
+});

packages/turf-nearest-point/index.ts

@@ -1,15 +1,15 @@
-import { Feature, FeatureCollection, Point } from "geojson";
+import { Feature, FeatureCollection, GeoJsonProperties, Point } from "geojson";
 import { Coord, Units } from "@turf/helpers";
 import { clone } from "@turf/clone";
 import { distance } from "@turf/distance";
 import { featureEach } from "@turf/meta";
 
-interface NearestPoint extends Feature<Point> {
+interface NearestPoint<P extends GeoJsonProperties = GeoJsonProperties>
+  extends Feature<Point> {
   properties: {
     featureIndex: number;
     distanceToPoint: number;
-    [key: string]: any;
-  };
+  } & P;
 }
 
 /**
@@ -38,13 +38,13 @@ interface NearestPoint extends Feature<Point> {
  * var addToMap = [targetPoint, points, nearest];
  * nearest.properties['marker-color'] = '#F00';
  */
-function nearestPoint(
+function nearestPoint<P extends GeoJsonProperties = GeoJsonProperties>(
   targetPoint: Coord,
-  points: FeatureCollection<Point>,
+  points: FeatureCollection<Point, P>,
   options: {
     units?: Units;
   } = {}
-): NearestPoint {
+): NearestPoint<P> {
   // Input validation
   if (!targetPoint) throw new Error("targetPoint is required");
   if (!points) throw new Error("points is required");

packages/turf-transform-translate/index.ts

@@ -9,6 +9,9 @@ import { rhumbDestination } from "@turf/rhumb-destination";
  * Moves any geojson Feature or Geometry of a specified distance along a Rhumb Line
  * on the provided direction angle.
  *
+ * Note that this moves the points of your shape individually and can therefore change
+ * the overall shape. How noticable this is depends on the distance and the used projection.
+ *
  * @function
  * @param {GeoJSON|GeometryCollection} geojson object to be translated
  * @param {number} distance length of the motion; negative values determine motion in opposite direction