Allow validation of GeometryCollection geometries with booleanValid in package boolean-valid #2916
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ltkum
commented
Jul 8, 2025
ltkum
commented
- Added a check to validate Geometry Collections in the booleanValid function
- We enforce the recommendations of not nesting Geometry Collections, as it will allow us to avoid infinite potential infinite validation loops
- Added tests files to ensure this work as expected.
Issue: We want to validate geometry collections, and the booleanValid() function does not allow us to do so. Fix: We add a verification for the `GeometryCollection` type in the booleanValid() function, and ensure it can't recurse indefinitely over itself.
We are also modifying the type checking
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.