Skip to content

Commit 19a08da

Browse files
committed
Add more detail to README
1 parent 895f8a0 commit 19a08da

File tree

1 file changed

+2
-2
lines changed

1 file changed

+2
-2
lines changed

README.md

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -65,8 +65,8 @@ If the Julia process successfully finishes, it will print the result which is pi
6565

6666
Finally, the results are collated and sent to the final job in the workflow, which is `python ad.py html`.
6767
This bit of the Python script is responsible for generating the three JSON files which the web app uses.
68-
(Fun fact: collating these results is also somewhat involved because we can't just write to `$GITHUB_OUTPUT`; it turns out that [output from different jobs in a matrix will override each other](https://github.com/orgs/community/discussions/26639).
69-
Thankfully, [there is an existing action](https://github.com/beacon-biosignals/matrix-output) which is designed to get around this problem by uploading artefacts.)
68+
(Fun fact: collating these results is also somewhat involved because we can't just write to `$GITHUB_OUTPUT`; it turns out that [output from different jobs in a matrix will override each other](https://github.com/orgs/community/discussions/26639), so the output can't share the same key, and there's [no way to dynamically specify the output key](https://github.com/actions/runner/pull/2477).
69+
Thankfully, [there is an existing action](https://github.com/beacon-biosignals/matrix-output) which is designed to get around this problem by uploading artefacts instead of using `$GITHUB_OUTPUT`.)
7070

7171
Overall, what this means is that the entire table can be generated in around 10 minutes (longer if you need to install + precompile dependencies, but on GitHub Actions dependencies will for the most part have been cached).
7272

0 commit comments

Comments
 (0)