Undelete some not-actually-dead code

Author: penelopeysm

src/logging.jl

@@ -57,3 +57,13 @@ function with_progresslogger(f, _module, logger)
 
     return Logging.with_logger(f, LoggingExtras.TeeLogger(logger1, logger2))
 end
+
+function progresslogger()
+    # detect if code is running under IJulia since TerminalLogger does not work with IJulia
+    # https://github.com/JuliaLang/IJulia.jl#detecting-that-code-is-running-under-ijulia
+    if (isdefined(Main, :IJulia) && Main.IJulia.inited)
+        return ConsoleProgressMonitor.ProgressLogger()
+    else
+        return TerminalLoggers.TerminalLogger()
+    end
+end

src/sample.jl

@@ -304,7 +304,7 @@ function mcmcsample(
     sampler::AbstractSampler,
     isdone;
     chain_type::Type=Any,
-    progress=PROGRESS[],
+    progress::Bool=PROGRESS[],
     progressname="Convergence sampling",
     callback=nothing,
     num_warmup=0,
@@ -328,7 +328,7 @@ function mcmcsample(
     start = time()
     local state
 
-    @ifwithprogresslogger (progress == true) name = progressname begin
+    @ifwithprogresslogger progress name = progressname begin
         # Obtain the initial sample and state.
         sample, state = if num_warmup > 0
             if initial_state === nothing