Skip to content

Commit 8d63557

Browse files
committed
apply suggestions
1 parent a4d2f5d commit 8d63557

File tree

1 file changed

+6
-5
lines changed

1 file changed

+6
-5
lines changed

src/AbstractMCMC.jl

Lines changed: 6 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -81,14 +81,16 @@ The `MCMCSerial` algorithm allows users to sample serially, with no thread or pr
8181
struct MCMCSerial <: AbstractMCMCEnsemble end
8282

8383
"""
84-
getparams(state[, logdensity_function])
84+
getparams(model::AbstractModel, state)
85+
getparams(state)
8586
8687
Retrieve the values of parameters from the sampler's `state` as a `Vector{<:Real}`.
8788
"""
8889
function getparams end
8990

9091
"""
91-
setparams!!(state, params[, logdensity_function])
92+
setparams!!(model::AbstractModel, state, params)
93+
setparams!!(state, params)
9294
9395
Set the values of parameters in the sampler's `state` from a `Vector{<:Real}`.
9496
@@ -99,9 +101,8 @@ Although not enforced, it should hold that `setparams!!(state, getparams(state))
99101
words, the sampler should implement a consistent transformation between its internal representation
100102
and the vector representation of the parameter values.
101103
102-
Sometimes, to maintain the consistency of the log density and parameter values, an optional
103-
`logdensity_function` can be provided. This is useful for samplers that need to evaluate the
104-
log density at the new parameter values.
104+
Sometimes, to maintain the consistency of the log density and parameter values, a `model::AbstractModel`
105+
should be provided. This is useful for samplers that need to evaluate the log density at the new parameter values.
105106
"""
106107
function setparams!! end
107108

0 commit comments

Comments
 (0)