Skip to content

Default bundle_samples is quite annoying #118

@torfjelde

Description

@torfjelde

The default implementation of bundle_samples specializes on Vector{T}, which in becomes very annoying if you want to implement your own bundle_samples, e.g. if you then use AbstractVector you almost immediately run into ambiguity errors.

function bundle_samples(
samples::Vector, ::AbstractModel, ::AbstractSampler, ::Any, ::Type{Vector{T}}; kwargs...
) where {T}
return map(samples) do sample
convert(T, sample)
end
end

In addition, IIUC it seems quite "useless" given that by default sample already returns a Vector of the transitions?

Thoughts on removing this?

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions