Skip to content

Commit c72faab

Browse files
committed
added some weird behavior from existing codebase...
1 parent b596c11 commit c72faab

File tree

1 file changed

+3
-3
lines changed

1 file changed

+3
-3
lines changed

src/varname.jl

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -172,7 +172,7 @@ Base.Symbol(vn::VarName) = Symbol(string(vn)) # simplified symbol
172172
inspace(vn::Union{VarName, Symbol}, space::Tuple)
173173
174174
Check whether `vn`'s variable symbol is in `space`. The empty tuple counts as the "universal space"
175-
containing all variables. Subsumption (see [`subsume`](@ref)) is respected.
175+
containing all variables. Subsumption (see [`subsume`](@ref)) is respected.
176176
177177
## Examples
178178
@@ -389,11 +389,11 @@ const ConcreteIndex = Union{Int, AbstractVector{Int}} # this include all kinds o
389389
"""Determine whether indices `i` are contained in `j`, treating `:` as universal set."""
390390
_issubrange(i::ConcreteIndex, j::ConcreteIndex) = issubset(i, j)
391391
_issubrange(i::Colon, j::Colon) = true
392-
_issubrange(i::Colon, j::ConcreteIndex) = false
392+
_issubrange(i::ConcreteIndex, j::Colon) = true
393393
# FIXME: [2021-07-31] This is wrong but we have tests in DPPL that tell
394394
# us that it SHOULD be correct. I'll leave it as is for now to ensure that
395395
# we preserve the status quo, but I'm confused.
396-
_issubrange(i::ConcreteIndex, j::Colon) = false
396+
_issubrange(i::Colon, j::ConcreteIndex) = true
397397

398398
"""
399399
concretize(l::Lens, x)

0 commit comments

Comments
 (0)