Skip to content

Conversation

penelopeysm
Copy link
Member

@penelopeysm penelopeysm commented Oct 5, 2025

varname_leaves didn't have a method for our best friend Cholesky. I need it in order to make penelopeysm/FlexiChains.jl#34 work nicely.

Also adds a series of tests for varname_leaves and varname_and_value_leaves.

Closes #138

Copy link
Contributor

github-actions bot commented Oct 5, 2025

AbstractPPL.jl documentation for PR #141 is available at:
https://TuringLang.github.io/AbstractPPL.jl/previews/PR141/

Copy link

codecov bot commented Oct 5, 2025

Codecov Report

❌ Patch coverage is 83.33333% with 2 lines in your changes missing coverage. Please review.
✅ Project coverage is 86.28%. Comparing base (5505e05) to head (fa8030f).
⚠️ Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
src/varname/leaves.jl 83.33% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #141      +/-   ##
==========================================
+ Coverage   78.81%   86.28%   +7.46%     
==========================================
  Files           9        9              
  Lines         439      452      +13     
==========================================
+ Hits          346      390      +44     
+ Misses         93       62      -31     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@penelopeysm
Copy link
Member Author

penelopeysm commented Oct 5, 2025

I'm so confused, I thought I formatted.

Edit: Turns out I didn't have my local pre-commit config on this repo.

@penelopeysm penelopeysm merged commit 3f6c538 into main Oct 5, 2025
10 of 11 checks passed
@penelopeysm penelopeysm deleted the py/leaves branch October 5, 2025 15:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add more tests for varname_{,and_value_}leaves
1 participant