From 73f71142df602b51bc0ac3c47a5073a777fa3898 Mon Sep 17 00:00:00 2001
From: "copilot-swe-agent[bot]" <198982749+Copilot@users.noreply.github.com>
Date: Thu, 28 Aug 2025 00:02:12 +0000
Subject: [PATCH 1/4] Initial plan


From b2df755c15d284e4b20fe75d441f567beaf287f6 Mon Sep 17 00:00:00 2001
From: "copilot-swe-agent[bot]" <198982749+Copilot@users.noreply.github.com>
Date: Thu, 28 Aug 2025 00:17:41 +0000
Subject: [PATCH 2/4] Add Aqua tests for automated quality assurance

Co-authored-by: yebai <3279477+yebai@users.noreply.github.com>
---
 test/Aqua.jl      | 10 ++++++++++
 test/Project.toml |  2 ++
 test/runtests.jl  |  4 ++++
 3 files changed, 16 insertions(+)
 create mode 100644 test/Aqua.jl

diff --git a/test/Aqua.jl b/test/Aqua.jl
new file mode 100644
index 0000000..b21769a
--- /dev/null
+++ b/test/Aqua.jl
@@ -0,0 +1,10 @@
+module AquaTests
+
+using Aqua: Aqua
+using AbstractPPL
+
+# For now, we skip ambiguities since they come from interactions
+# with third-party packages rather than issues in AbstractPPL itself
+Aqua.test_all(AbstractPPL; ambiguities=false)
+
+end
\ No newline at end of file
diff --git a/test/Project.toml b/test/Project.toml
index 23fb280..f0de017 100644
--- a/test/Project.toml
+++ b/test/Project.toml
@@ -1,5 +1,6 @@
 [deps]
 Accessors = "7d9f7c33-5ae7-4f3b-8dc6-eff91059b697"
+Aqua = "4c88cf16-eb10-579e-8560-4a9242c79595"
 Distributions = "31c24e10-a181-5473-b8eb-7969acd0382f"
 Documenter = "e30172f5-a6a5-5a46-863b-614d45cd2de4"
 InvertedIndices = "41ab1584-1d38-5bbf-9106-f11c6c58b48f"
@@ -10,6 +11,7 @@ Test = "8dfed614-e22c-5e08-85e1-65c5234f0b40"
 
 [compat]
 Accessors = "0.1"
+Aqua = "0.8"
 Documenter = "0.26.3, 0.27, 1"
 InvertedIndices = "1"
 OffsetArrays = "1"
diff --git a/test/runtests.jl b/test/runtests.jl
index b71a812..d11b035 100644
--- a/test/runtests.jl
+++ b/test/runtests.jl
@@ -3,9 +3,13 @@ using Documenter
 using Test
 
 const GROUP = get(ENV, "GROUP", "All")
+const AQUA = get(ENV, "AQUA", "true") == "true"
 
 @testset "AbstractPPL.jl" begin
     if GROUP == "All" || GROUP == "Tests"
+        if AQUA
+            include("Aqua.jl")
+        end
         include("varname.jl")
         include("abstractprobprog.jl")
         include("hasvalue.jl")

From 8182dea0cbce2dfc04e6edecc6342b9fb8667deb Mon Sep 17 00:00:00 2001
From: Hong Ge <3279477+yebai@users.noreply.github.com>
Date: Thu, 28 Aug 2025 01:29:33 +0100
Subject: [PATCH 3/4] Fix missing newline at end of Aqua.jl

---
 test/Aqua.jl | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/test/Aqua.jl b/test/Aqua.jl
index b21769a..6f608e2 100644
--- a/test/Aqua.jl
+++ b/test/Aqua.jl
@@ -7,4 +7,4 @@ using AbstractPPL
 # with third-party packages rather than issues in AbstractPPL itself
 Aqua.test_all(AbstractPPL; ambiguities=false)
 
-end
\ No newline at end of file
+end

From c44ff2788cc4a84b40ca79ee2b740482e3a1a98d Mon Sep 17 00:00:00 2001
From: "copilot-swe-agent[bot]" <198982749+Copilot@users.noreply.github.com>
Date: Thu, 28 Aug 2025 01:20:02 +0000
Subject: [PATCH 4/4] Remove AQUA environment variable and always run Aqua
 tests in All/Tests groups

Co-authored-by: yebai <3279477+yebai@users.noreply.github.com>
---
 test/runtests.jl | 5 +----
 1 file changed, 1 insertion(+), 4 deletions(-)

diff --git a/test/runtests.jl b/test/runtests.jl
index d11b035..cb07ee0 100644
--- a/test/runtests.jl
+++ b/test/runtests.jl
@@ -3,13 +3,10 @@ using Documenter
 using Test
 
 const GROUP = get(ENV, "GROUP", "All")
-const AQUA = get(ENV, "AQUA", "true") == "true"
 
 @testset "AbstractPPL.jl" begin
     if GROUP == "All" || GROUP == "Tests"
-        if AQUA
-            include("Aqua.jl")
-        end
+        include("Aqua.jl")
         include("varname.jl")
         include("abstractprobprog.jl")
         include("hasvalue.jl")