Removed type piracy

Author: charlesknipp

src/model.jl

@@ -21,7 +21,6 @@ mutable struct TracedSSM{SSM} <: SSMProblems.AbstractStateSpaceModel
     end
 end
 
-(model::SSMProblems.StateSpaceModel)(Y::AbstractVector) = TracedSSM(model, Y)
 prior(ssm::TracedSSM) = ssm.model.prior
 dynamics(ssm::TracedSSM, step::Int) = ssm.model.dyn
 observation(ssm::TracedSSM, step::Int) = ssm.model.obs

test/container.jl

@@ -8,13 +8,13 @@
     end
 
     SSMProblems.logdensity(proc::LogPObservation, ::Int, state, observation) = proc.logp
-    SSMProblems.distribution(proc::LogPDynamics, ::Int, state) = Uniform()
+    SSMProblems.distribution(::LogPDynamics, ::Int, state) = Uniform()
     SSMProblems.distribution(::LogPPrior) = Uniform()
 
     function LogPModel(logp::T) where {T<:Real}
         ssm = StateSpaceModel(LogPPrior(), LogPDynamics(), LogPObservation(logp))
         # pick some arbitrarily large observables
-        return ssm(ones(T, 10))
+        return AdvancedPS.TracedSSM(ssm, ones(T, 10))
     end
 
     @testset "copy particle container" begin

test/linear-gaussian.jl

@@ -94,7 +94,7 @@ end
     end
 
     lgssm = LinearGaussianStateSpaceModel(X0, P0, A, B, Q, H, R)
-    model = lgssm(ys)
+    model = AdvancedPS.TracedSSM(lgssm, ys)
 
     @testset "PGAS" begin
         pgas = AdvancedPS.PGAS(N_PARTICLES)

test/pgas.jl

@@ -36,7 +36,7 @@
         dyn = BaseModelDynamics(θ.a, θ.q)
         obs = BaseModelObservation(θ.r)
         ssm = StateSpaceModel(prior, dyn, obs)
-        return ssm(zeros(T, 3))
+        return AdvancedPS.TracedSSM(ssm, zeros(T, 3))
     end
 
     @testset "fork reference" begin