Add more tests

Author: penelopeysm

src/sampler.jl

@@ -68,9 +68,8 @@ function _convert_initial_params(d::AbstractDict{<:VarName})
     return InitFromParams(d)
 end
 function _convert_initial_params(::AbstractVector)
-    return error(
-        "`initial_params` must be a `NamedTuple`, an `AbstractDict{<:VarName}`, or ideally an `AbstractInitStrategy`. Using a vector of parameters for `initial_params` is no longer supported. Please see https://turinglang.org/docs/usage/sampling-options/#specifying-initial-parameters for details on how to update your code.",
-    )
+    errmsg = "`initial_params` must be a `NamedTuple`, an `AbstractDict{<:VarName}`, or ideally an `AbstractInitStrategy`. Using a vector of parameters for `initial_params` is no longer supported. Please see https://turinglang.org/docs/usage/sampling-options/#specifying-initial-parameters for details on how to update your code."
+    throw(ArgumentError(errmsg))
 end
 
 function AbstractMCMC.sample(

test/sampler.jl

@@ -138,6 +138,14 @@
                 end
             end
 
+            # check that Vector no longer works
+            @test_throws ArgumentError sample(
+                model, sampler, 1; initial_params=[4, -1], progress=false
+            )
+            @test_throws ArgumentError sample(
+                model, sampler, 1; initial_params=[missing, -1], progress=false
+            )
+
             # model with two variables: initialization s = 4, m = -1
             @model function twovars()
                 s ~ InverseGamma(2, 3)
@@ -181,7 +189,8 @@
                 Dict(@varname(s) => missing, @varname(m) => -1),
                 InitFromParams((; m=-1)),
                 InitFromParams(Dict(@varname(m) => -1)),
-                (; m=-1)Dict(@varname(m) => -1),
+                (; m=-1),
+                Dict(@varname(m) => -1),
             )
                 chain = sample(model, sampler, 1; initial_params=inits, progress=false)
                 @test !ismissing(chain[1].metadata.s.vals[1])