Fix setlogp!! with single scalar to error

Author: mhauru

HISTORY.md

@@ -16,7 +16,7 @@ This release overhauls how VarInfo objects track variables such as the log joint
   - `set/reset/increment_num_produce!` have become `set/reset/increment_num_produce!!` (note the second exclamation mark). They are no longer guaranteed to modify the `VarInfo` in place, and one should always use the return value.
   - `@addlogprob!` now _always_ adds to the log likelihood. Previously it added to the log probability that the execution context specified, e.g. the log prior when using `PriorContext`.
   - `getlogp` now returns a `NamedTuple` with keys `logprior` and `loglikelihood`. If you want the log joint probability, which is what `getlogp` used to return, use `getlogjoint`.
-  - Correspondingly `setlogp!!` and `acclogp!!` should now be called with a `NamedTuple` with keys `logprior` and `loglikelihood`. The method with a single scalar value has been deprecated, and falls back on `setloglikelihood!!` or `accloglikelihood!!`. Corresponding setter/accumulator functions exist for the log prior as well.
+  - Correspondingly `setlogp!!` and `acclogp!!` should now be called with a `NamedTuple` with keys `logprior` and `loglikelihood`. The `acclogp!!` method with a single scalar value has been deprecated and falls back on `accloglikelihood!!`, and the single scalar version of `setlogp!!` has been removed. Corresponding setter/accumulator functions exist for the log prior as well.
 
 ## 0.36.0
 

src/abstract_varinfo.jl

@@ -224,11 +224,10 @@ function setlogp!!(vi::AbstractVarInfo, logp::NamedTuple{names}) where {names}
 end
 
 function setlogp!!(vi::AbstractVarInfo, logp::Number)
-    depwarn(
-        "`setlogp!!(vi::AbstractVarInfo, logp::Number)` is deprecated. Use `setloglikelihood!!(vi, logp)` instead.",
-        :setlogp,
-    )
-    return setloglikelihood!!(vi, logp)
+    return error("""
+                 `setlogp!!(vi::AbstractVarInfo, logp::Number)` is no longer supported. Use
+                 `setloglikelihood!!`  and/or `setlogprior!!` instead.
+                 """)
 end
 
 """

test/varinfo.jl

@@ -220,7 +220,6 @@ end
             vi = setlogprior!!(vi, -1.0)
             getlogprior(vi) == -1.0
         end
-        @test_throws "has no field LogLikelihood" setlogp!!(getlogp(vi))
 
         vi = last(
             DynamicPPL.evaluate!!(m, DynamicPPL.setaccs!!(deepcopy(vi), (NumProduce(),)))