Skip to content

Commit 2161352

Browse files
mhaurupenelopeysm
andauthored
Apply suggestions from code review
Co-authored-by: Penelope Yong <[email protected]>
1 parent c95d298 commit 2161352

File tree

2 files changed

+3
-3
lines changed

2 files changed

+3
-3
lines changed

benchmarks/README.md

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,4 @@
1-
To run the benchmarks, simply do this from the root directory of the repository:
1+
To run the benchmarks, run this from the root directory of the repository:
22

33
```sh
44
julia --project=benchmarks benchmarks/benchmarks.jl

benchmarks/src/DynamicPPLBenchmarks.jl

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -32,7 +32,7 @@ end
3232
# Utility functions for representing AD backends using symbols.
3333
# Copied from TuringBenchmarking.jl.
3434
const SYMBOL_TO_BACKEND = Dict(
35-
:forwarddiff => ADTypes.AutoForwardDiff(; chunksize=0),
35+
:forwarddiff => ADTypes.AutoForwardDiff(),
3636
:reversediff => ADTypes.AutoReverseDiff(; compile=false),
3737
:reversediff_compiled => ADTypes.AutoReverseDiff(; compile=true),
3838
:mooncake => ADTypes.AutoMooncake(; config=nothing),
@@ -104,7 +104,7 @@ function make_suite(model, varinfo_choice::Symbol, adbackend::Symbol, islinked::
104104
suite["gradient"] = @benchmarkable $(LogDensityProblems.logdensity_and_gradient)($f, $θ)
105105

106106
# Also benchmark just standard model evaluation because why not.
107-
suite["evaluation"] = @benchmarkable $(DynamicPPL.evaluate!!)($model, $vi, $context)
107+
suite["evaluation"] = @benchmarkable $(LogDensityProblems.logdensity)($f, $θ)
108108

109109
return suite
110110
end

0 commit comments

Comments
 (0)