Skip to content

Commit 2976bbf

Browse files
committed
2nd round of reviewdog fixes
1 parent e8710b3 commit 2976bbf

File tree

2 files changed

+11
-6
lines changed

2 files changed

+11
-6
lines changed

src/distribution_wrappers.jl

Lines changed: 2 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -6,8 +6,7 @@ using Distributions: Univariate, Multivariate, Matrixvariate
66
Base type for distribution wrappers.
77
"""
88
abstract type WrappedDistribution{variate,support,Td<:Distribution{variate,support}} <:
9-
Distribution{variate,support}
10-
end
9+
Distribution{variate,support} end
1110

1211
wrapped_dist_type(::Type{<:WrappedDistribution{<:Any,<:Any,Td}}) where {Td} = Td
1312
wrapped_dist_type(d::WrappedDistribution) = wrapped_dist_type(d)
@@ -20,7 +19,7 @@ Base.eltype(::Type{T}) where {T<:WrappedDistribution} = eltype(wrapped_dist_type
2019
Base.eltype(d::WrappedDistribution) = eltype(wrapped_dist_type(d))
2120

2221
function Distributions.rand(rng::Random.AbstractRNG, d::WrappedDistribution)
23-
rand(rng, wrapped_dist(d))
22+
return rand(rng, wrapped_dist(d))
2423
end
2524
Distributions.minimum(d::WrappedDistribution) = minimum(wrapped_dist(d))
2625
Distributions.maximum(d::WrappedDistribution) = maximum(wrapped_dist(d))

test/context_implementations.jl

Lines changed: 9 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -82,14 +82,20 @@
8282
# test for bijector
8383
link!(vi_gen, DynamicPPL.SampleFromPrior())
8484
invlink!(vi_gen, DynamicPPL.SampleFromPrior())
85-
85+
8686
# explicit model specification
8787
expl_model = DynamicPPL.Model(NamedTuple()) do model, varinfo, context
88-
DynamicPPL.tilde_assume!!(context, NoDist(Product(fill(Uniform(-20, 20), 5))), @varname(x), varinfo)
88+
DynamicPPL.tilde_assume!!(
89+
context,
90+
NoDist(Product(fill(Uniform(-20, 20), 5))),
91+
@varname(x),
92+
varinfo
93+
)
8994
x = varinfo[@varname(x)]
9095
@test x isa Vector{<:Real}
9196
@test length(x) == 5
92-
return nothing, DynamicPPL.acclogp!!(varinfo, sum(logpdf.(Ref(Normal(0, 1)), x)))
97+
return (nothing,
98+
DynamicPPL.acclogp!!(varinfo, sum(logpdf.(Ref(Normal(0, 1)), x))))
9399
end
94100
vi_expl = VarInfo(expl_model)
95101
@test isfinite(logjoint(expl_model, vi_expl))

0 commit comments

Comments
 (0)