Do not reset logp in evaluator

devmotion · devmotion · commit 3d2c1eb21a17 · 2020-04-09T10:38:25.000+02:00
diff --git a/src/compiler.jl b/src/compiler.jl
@@ -443,7 +443,6 @@ function build_output(model_info)
             $ctx::$(DynamicPPL.AbstractContext),
         )
             $unwrap_data_expr
-            $(DynamicPPL.resetlogp!)($vi)
             $main_body
             return
         end
diff --git a/src/model.jl b/src/model.jl
@@ -131,7 +131,7 @@ function runmodel!(
     spl::AbstractSampler=SampleFromPrior(),
     ctx::AbstractContext=DefaultContext()
 )
-    setlogp!(vi, 0)
+    resetlogp!(vi)
     if has_eval_num(spl)
         spl.state.eval_num += 1
     end

Original file line number	Diff line number	Diff line change
`@@ -443,7 +443,6 @@ function build_output(model_info)`
`443`	`443`	`$ctx::$(DynamicPPL.AbstractContext),`
`444`	`444`	`)`
`445`	`445`	`$unwrap_data_expr`
`446`		`- $(DynamicPPL.resetlogp!)($vi)`
`447`	`446`	`$main_body`
`448`	`447`	`return`
`449`	`448`	`end`
Original file line number	Diff line number	Diff line change
`@@ -131,7 +131,7 @@ function runmodel!(`
`131`	`131`	`spl::AbstractSampler=SampleFromPrior(),`
`132`	`132`	`ctx::AbstractContext=DefaultContext()`
`133`	`133`	`)`
`134`		`- setlogp!(vi, 0)`
	`134`	`+ resetlogp!(vi)`
`135`	`135`	`if has_eval_num(spl)`
`136`	`136`	`spl.state.eval_num += 1`
`137`	`137`	`end`