Skip to content

Commit 70d124a

Browse files
penelopeysmmhauru
andauthored
Apply suggestions from code review
Co-authored-by: Markus Hauru <[email protected]>
1 parent b545a93 commit 70d124a

File tree

3 files changed

+3
-4
lines changed

3 files changed

+3
-4
lines changed

HISTORY.md

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -19,7 +19,7 @@ end
1919
end
2020
```
2121

22-
and the `inner.x` variable will be correctly conditioned.
22+
and the `a.x` variable will be correctly conditioned.
2323
(Previously, you would have to condition `inner()` with the variable `a.x`, meaning that you would need to know what prefix to use before you had actually prefixed it.)
2424

2525
### AD testing utilities

docs/src/api.md

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -78,9 +78,9 @@ decondition
7878

7979
## Fixing and unfixing
8080

81-
We can also _fix_ a collection of variables in a [`Model`](@ref) to certain using [`DynamicPPL.fix`](@ref).
81+
We can also _fix_ a collection of variables in a [`Model`](@ref) to certain values using [`DynamicPPL.fix`](@ref).
8282

83-
This might seem quite similar to the aforementioned [`condition`](@ref) and its siblings,
83+
This is quite similar to the aforementioned [`condition`](@ref) and its siblings,
8484
but they are indeed different operations:
8585

8686
- `condition`ed variables are considered to be _observations_, and are thus

test/contexts.jl

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -105,7 +105,6 @@ Base.IteratorEltype(::Type{<:AbstractContext}) = Base.EltypeUnknown()
105105
vcat,
106106
pairs(conditioned_values),
107107
)
108-
@show conditioned_vns
109108

110109
# We can now loop over them to check which ones are missing. We use
111110
# `getvalue` to handle the awkward case where sometimes

0 commit comments

Comments
 (0)