Remove getspace

Author: mhauru

HISTORY.md

@@ -16,7 +16,7 @@ This release removes the feature of `VarInfo` where it kept track of which varia
   - `keys(::VarInfo)` no longer accepts a sampler as an argument
   - `VarInfo(::VarInfo, ::Sampler, ::AbstactVector)` no longer accepts the sampler argument.
   - `push!!` and `push!` no longer accept samplers or `Selector`s as arguments
-  - `getgid`, `setgid!`, `updategid!`, and `inspace` no longer exist
+  - `getgid`, `setgid!`, `updategid!`, `getspace`, and `inspace` no longer exist
 
 ### Reverse prefixing order
 

src/DynamicPPL.jl

@@ -149,9 +149,6 @@ macro prob_str(str)
     ))
 end
 
-# Used here and overloaded in Turing
-function getspace end
-
 """
     AbstractVarInfo
 

src/sampler.jl

@@ -18,8 +18,6 @@ Sampling algorithm that samples unobserved random variables from their prior dis
 """
 struct SampleFromPrior <: AbstractSampler end
 
-getspace(::Union{SampleFromPrior,SampleFromUniform}) = ()
-
 # Initializations.
 init(rng, dist, ::SampleFromPrior) = rand(rng, dist)
 function init(rng, dist, ::SampleFromUniform)

test/ad.jl

@@ -41,7 +41,7 @@
         σ = 0.3
         y = @. rand(sin(t) + Normal(0, σ))
         @model function state_space(y, TT, ::Type{T}=Float64) where {T}
-            # Priors 
+            # Priors
             α ~ Normal(y[1], 0.001)
             τ ~ Exponential(1)
             η ~ filldist(Normal(0, 1), TT - 1)
@@ -63,7 +63,6 @@
         # overload assume so that model evaluation doesn't fail due to a lack
         # of implementation
         struct MyEmptyAlg end
-        DynamicPPL.getspace(::DynamicPPL.Sampler{MyEmptyAlg}) = ()
         DynamicPPL.assume(rng, ::DynamicPPL.Sampler{MyEmptyAlg}, dist, vn, vi) =
             DynamicPPL.assume(dist, vn, vi)
 

test/sampler.jl

@@ -67,7 +67,6 @@
         )
             return vi, nothing
         end
-        DynamicPPL.getspace(::Sampler{<:OnlyInitAlg}) = ()
 
         # initial samplers
         DynamicPPL.initialsampler(::Sampler{OnlyInitAlgUniform}) = SampleFromUniform()