Skip to content

Commit da3eefe

Browse files
committed
removed unnecessary typed_varinfo and untyped_varinfo methods
1 parent 3aad34f commit da3eefe

File tree

1 file changed

+5
-22
lines changed

1 file changed

+5
-22
lines changed

src/varinfo.jl

Lines changed: 5 additions & 22 deletions
Original file line numberDiff line numberDiff line change
@@ -163,37 +163,20 @@ function has_varnamedvector(vi::VarInfo)
163163
(vi isa TypedVarInfo && any(Base.Fix2(isa, VarNamedVector), values(vi.metadata)))
164164
end
165165

166-
# TODO: We should just remove this function in favour of passing `SamplingContext` directly.
167-
function untyped_varinfo(
168-
rng::Random.AbstractRNG,
169-
model::Model,
170-
sampler::AbstractSampler=SampleFromPrior(),
171-
context::AbstractContext=DefaultContext(),
172-
metadata::Union{Metadata,VarNamedVector}=Metadata(),
173-
)
174-
return untyped_varinfo(model, SamplingContext(rng, sampler, context), metadata)
175-
end
176-
function untyped_varinfo(
177-
model::Model, args::Union{AbstractSampler,AbstractContext,Metadata,VarNamedVector}...
178-
)
179-
return untyped_varinfo(Random.default_rng(), model, args...)
180-
end
181-
182166
"""
183-
untyped_varinfo([rng, ]model[, context, metadata])
167+
untyped_varinfo(model[, context, metadata])
184168
185169
Return an untyped varinfo object for the given `model` and `context`.
186170
187171
# Arguments
188-
- `rng::Random.AbstractRNG`: The random number generator to use. Default: `Random.default_rng()`.
189172
- `model::Model`: The model for which to create the varinfo object.
190-
- `context::AbstractContext`: The context in which to evaluate the model. Default: `DefaultContext()`.
173+
- `context::AbstractContext`: The context in which to evaluate the model. Default: `SamplingContext()`.
191174
- `metadata::Union{Metadata,VarNamedVector}`: The metadata to use for the varinfo object.
192175
Default: `Metadata()`.
193176
"""
194177
function untyped_varinfo(
195178
model::Model,
196-
context::AbstractContext,
179+
context::AbstractContext=SamplingContext(),
197180
metadata::Union{Metadata,VarNamedVector}=Metadata(),
198181
)
199182
varinfo = VarInfo(metadata)
@@ -203,7 +186,7 @@ function untyped_varinfo(
203186
end
204187

205188
"""
206-
typed_varinfo([rng, ]model[, context, metadata])
189+
typed_varinfo(model[, context, metadata])
207190
208191
Return a typed varinfo object for the given `model`, `sampler` and `context`.
209192
@@ -221,7 +204,7 @@ function VarInfo(
221204
context::AbstractContext=DefaultContext(),
222205
metadata::Union{Metadata,VarNamedVector}=Metadata(),
223206
)
224-
return typed_varinfo(rng, model, sampler, context, metadata)
207+
return typed_varinfo(model, SamplingContext(rng, sampler, context), metadata)
225208
end
226209
VarInfo(model::Model, args...) = VarInfo(Random.default_rng(), model, args...)
227210

0 commit comments

Comments
 (0)