Skip to content

Commit fcdfe03

Browse files
wsmosespenelopeysm
andauthored
Don't use closure for enzyme (#1048)
* Don't use closure for enzyme * no annotation * bump patch --------- Co-authored-by: Penelope Yong <[email protected]>
1 parent 0af3894 commit fcdfe03

File tree

4 files changed

+8
-5
lines changed

4 files changed

+8
-5
lines changed

HISTORY.md

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,9 @@
11
# DynamicPPL Changelog
22

3+
## 0.37.5
4+
5+
A minor optimisation for Enzyme AD on DynamicPPL models.
6+
37
## 0.37.4
48

59
An extension for MarginalLogDensities.jl has been added.

Project.toml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
name = "DynamicPPL"
22
uuid = "366bfd00-2699-11ea-058f-f148b4cae6d8"
3-
version = "0.37.4"
3+
version = "0.37.5"
44

55
[deps]
66
ADTypes = "47edcb42-4c32-4615-8424-f2b9edc5f35b"

src/logdensityfunction.jl

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -350,6 +350,7 @@ closure approach will be used. By default, this function returns `false`, i.e.
350350
the constant approach will be used.
351351
"""
352352
use_closure(::ADTypes.AbstractADType) = true
353+
use_closure(::ADTypes.AutoEnzyme) = false
353354

354355
"""
355356
getmodel(f)

test/integration/enzyme/main.jl

Lines changed: 2 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -6,10 +6,8 @@ import Enzyme: set_runtime_activity, Forward, Reverse, Const
66
using ForwardDiff: ForwardDiff # run_ad uses FD for correctness test
77

88
ADTYPES = Dict(
9-
"EnzymeForward" =>
10-
AutoEnzyme(; mode=set_runtime_activity(Forward), function_annotation=Const),
11-
"EnzymeReverse" =>
12-
AutoEnzyme(; mode=set_runtime_activity(Reverse), function_annotation=Const),
9+
"EnzymeForward" => AutoEnzyme(; mode=set_runtime_activity(Forward)),
10+
"EnzymeReverse" => AutoEnzyme(; mode=set_runtime_activity(Reverse)),
1311
)
1412

1513
@testset "$ad_key" for (ad_key, ad_type) in ADTYPES

0 commit comments

Comments
 (0)