You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Fix conditioned doctest for Julia 1.8-beta1 (#388)
The tests were failing on a changed display for var objects:
```
│ Subexpression:
│
│ conditioned(cm)
│
│ Evaluated output:
│
│ (x = 100.0, var"a.m" = 1.0)
│
│ Expected output:
│
│ (x = 100.0, a.m = 1.0)
│
│ diff =
│ Warning: Diff output requires color.
│ (x = 100.0, a.m var"a.m" = 1.0)
```
This is why the the nanosoldier runs show that DynamicPPL fails on Julia 1.8-beta1 (https://s3.amazonaws.com/julialang-reports/nanosoldier/pkgeval/by_hash/fb69baf_vs_40279f9/report.html).
I've tried to come up with a doctestfilter, but don't think that's possible in this case. Therefore, I suggest that we only run the tests on the latest stable release. This solves two problems:
- Nightly/beta/release-candidate releases failing due to changes in how output appears
- Simplify code; especially avoids that a doctestfilter allows some test to pass where it should fail
I've tested this PR on Julia 1.8.0-beta1 locally. All tests passed.
Co-authored-by: Rik Huijzer <[email protected]>
0 commit comments