Skip to content

Conversation

penelopeysm
Copy link
Member

@penelopeysm penelopeysm commented Sep 30, 2025

Removes resume_from=chn, replaces with initial_state=loadstate(chn).

Also removes default_chain_type. The reason why I want to do this is because it's one step towards removing Sampler. The replacement for this is to specify a default chain type in Turing rather than in DynamicPPL. I'll do that in a separate PR. (Notice that the default chain type is MCMCChains.Chains, but MCMCChains isn't a dep of DynamicPPL. So it just makes more sense to define this in Turing anyway.)

Closes TuringLang/Turing.jl#2675
Closes TuringLang/Turing.jl#2171
Closes #1049

@penelopeysm penelopeysm changed the title Remove resume_from Remove resume_from and default_chain_type Sep 30, 2025
@penelopeysm penelopeysm requested a review from sunxd3 September 30, 2025 17:26
Copy link
Contributor

DynamicPPL.jl documentation for PR #1061 is available at:
https://TuringLang.github.io/DynamicPPL.jl/previews/PR1061/

Copy link

codecov bot commented Sep 30, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 82.38%. Comparing base (08212a2) to head (c672e3a).
⚠️ Report is 1 commits behind head on breaking.

Additional details and impacted files
@@             Coverage Diff              @@
##           breaking    #1061      +/-   ##
============================================
- Coverage     82.39%   82.38%   -0.01%     
============================================
  Files            42       42              
  Lines          3818     3816       -2     
============================================
- Hits           3146     3144       -2     
  Misses          672      672              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Copy link
Member

@sunxd3 sunxd3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good

one tiny concern is whether this really closes #1049: I assume
https://github.com/TuringLang/DynamicPPL.jl/blob/c672e3adecf6e6409decd55bd1cdad90631c65ed/ext/DynamicPPLMCMCChainsExt.jl#L15C12-L15C37 does the right things for different kind of chains, but I thought it's worth mentioning.

@penelopeysm
Copy link
Member Author

penelopeysm commented Oct 1, 2025

Thanks @sunxd3! Yeah, that's fair. loadstate only works directly if the saved chain 'matches' the resuming chain in terms of the number of chains. My current thinking is that it's OK to not extend the interface, and instead document the format that it returns / the format that the next chain expects so that users can manipulate it themselves into the right format if needed - do you think that'd be alright? The documentation in this PR TuringLang/docs#654 :)

@penelopeysm
Copy link
Member Author

@penelopeysm penelopeysm merged commit 7abd5fb into breaking Oct 2, 2025
20 of 21 checks passed
@penelopeysm penelopeysm deleted the py/no-resume-from branch October 2, 2025 15:10
@sunxd3
Copy link
Member

sunxd3 commented Oct 5, 2025

@penelopeysm sorry for missing this -- looks good! thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants