Skip to content

ParamsWithStats: lp or logjoint? #1140

@penelopeysm

Description

@penelopeysm

I messed up and made one method lp and one logjoint:

logprior=DynamicPPL.getlogprior(varinfo),
loglikelihood=DynamicPPL.getloglikelihood(varinfo),
lp=DynamicPPL.getlogjoint(varinfo),

DynamicPPL.jl/src/chains.jl

Lines 130 to 132 in 8e359ce

if has_prior_acc && has_likelihood_acc
stats = merge(stats, (logjoint=DynamicPPL.getlogjoint(varinfo),))
end

Should probably choose one and stick with it.

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions