fixes

Author: penelopeysm

src/mcmc/abstractmcmc.jl

@@ -1,7 +1,9 @@
 # TODO: Implement additional checks for certain samplers, e.g.
 # HMC not supporting discrete parameters.
 function _check_model(model::DynamicPPL.Model)
-    return DynamicPPL.check_model(model; error_on_failure=true)
+    # TODO(DPPL0.37/penelopeysm): use InitContext
+    spl_model = DynamicPPL.contextualize(model, DynamicPPL.SamplingContext(model.context))
+    return DynamicPPL.check_model(spl_model, VarInfo(); error_on_failure=true)
 end
 function _check_model(model::DynamicPPL.Model, alg::InferenceAlgorithm)
     return _check_model(model)

test/ad.jl

@@ -172,14 +172,14 @@ function DynamicPPL.tilde_assume(
     return value, logp, vi
 end
 
-function DynamicPPL.tilde_observe(context::ADTypeCheckContext, right, left, vi)
-    logp, vi = DynamicPPL.tilde_observe(DynamicPPL.childcontext(context), right, left, vi)
+function DynamicPPL.tilde_observe!!(context::ADTypeCheckContext, right, left, vi)
+    logp, vi = DynamicPPL.tilde_observe!!(DynamicPPL.childcontext(context), right, left, vi)
     check_adtype(context, vi)
     return logp, vi
 end
 
-function DynamicPPL.tilde_observe(context::ADTypeCheckContext, sampler, right, left, vi)
-    logp, vi = DynamicPPL.tilde_observe(
+function DynamicPPL.tilde_observe!!(context::ADTypeCheckContext, sampler, right, left, vi)
+    logp, vi = DynamicPPL.tilde_observe!!(
         DynamicPPL.childcontext(context), sampler, right, left, vi
     )
     check_adtype(context, vi)