Skip to content

Commit 6088517

Browse files
authored
Merge branch 'master' into breaking
2 parents 5c440ce + ef6c257 commit 6088517

File tree

2 files changed

+2
-12
lines changed

2 files changed

+2
-12
lines changed

test/mcmc/ess.jl

Lines changed: 1 addition & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -66,11 +66,7 @@ using Turing
6666
@varname(mu2) => ESS(),
6767
)
6868
chain = sample(StableRNG(seed), MoGtest_default, alg, 2000)
69-
# (penelopeysm) Note that the tolerance for x86 needs to be larger
70-
# because CSMC (i.e. PG) is not reproducible across architectures.
71-
# See https://github.com/TuringLang/Turing.jl/issues/2446.
72-
atol = Sys.ARCH == :i686 ? 0.12 : 0.1
73-
check_MoGtest_default(chain; atol=atol)
69+
check_MoGtest_default(chain; atol=0.1)
7470
end
7571

7672
@testset "TestModels" begin

test/mcmc/gibbs.jl

Lines changed: 1 addition & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -450,13 +450,7 @@ end
450450
# the posterior is analytically known? Doing 10_000 samples to run the test suite
451451
# is not ideal
452452
# Issue ref: https://github.com/TuringLang/Turing.jl/issues/2402
453-
454-
# (penelopeysm) Note also the larger atol on x86 runners. This is
455-
# needed because PG is not fully reproducible across architectures,
456-
# even when seeded as above. See
457-
# https://github.com/TuringLang/Turing.jl/issues/2446
458-
mean_atol = Sys.ARCH == :i686 ? 1.3 : 0.8
459-
@test isapprox(mean(num_ms), 8.6087; atol=mean_atol)
453+
@test isapprox(mean(num_ms), 8.6087; atol=0.8)
460454
@test isapprox(std(num_ms), 1.8865; atol=0.02)
461455
end
462456

0 commit comments

Comments
 (0)