Skip to content

Commit b346198

Browse files
committed
fix return values of tilde pipeline
1 parent 283d4dd commit b346198

File tree

1 file changed

+8
-10
lines changed

1 file changed

+8
-10
lines changed

test/ad.jl

Lines changed: 8 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -155,35 +155,33 @@ end
155155
# child context.
156156

157157
function DynamicPPL.tilde_assume(context::ADTypeCheckContext, right, vn, vi)
158-
value, logp, vi = DynamicPPL.tilde_assume(
159-
DynamicPPL.childcontext(context), right, vn, vi
160-
)
158+
value, vi = DynamicPPL.tilde_assume(DynamicPPL.childcontext(context), right, vn, vi)
161159
check_adtype(context, vi)
162-
return value, logp, vi
160+
return value, vi
163161
end
164162

165163
function DynamicPPL.tilde_assume(
166164
rng::Random.AbstractRNG, context::ADTypeCheckContext, sampler, right, vn, vi
167165
)
168-
value, logp, vi = DynamicPPL.tilde_assume(
166+
value, vi = DynamicPPL.tilde_assume(
169167
rng, DynamicPPL.childcontext(context), sampler, right, vn, vi
170168
)
171169
check_adtype(context, vi)
172-
return value, logp, vi
170+
return value, vi
173171
end
174172

175173
function DynamicPPL.tilde_observe!!(context::ADTypeCheckContext, right, left, vi)
176-
logp, vi = DynamicPPL.tilde_observe!!(DynamicPPL.childcontext(context), right, left, vi)
174+
left, vi = DynamicPPL.tilde_observe!!(DynamicPPL.childcontext(context), right, left, vi)
177175
check_adtype(context, vi)
178-
return logp, vi
176+
return left, vi
179177
end
180178

181179
function DynamicPPL.tilde_observe!!(context::ADTypeCheckContext, sampler, right, left, vi)
182-
logp, vi = DynamicPPL.tilde_observe!!(
180+
left, vi = DynamicPPL.tilde_observe!!(
183181
DynamicPPL.childcontext(context), sampler, right, left, vi
184182
)
185183
check_adtype(context, vi)
186-
return logp, vi
184+
return left, vi
187185
end
188186

189187
"""

0 commit comments

Comments
 (0)