Skip to content

Commit b9b68c4

Browse files
committed
Remove conditional loading/exporting of Tapir
1 parent 97ed363 commit b9b68c4

File tree

11 files changed

+17
-53
lines changed

11 files changed

+17
-53
lines changed

Project.toml

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -73,14 +73,13 @@ LogDensityProblems = "2"
7373
LogDensityProblemsAD = "1.7.0"
7474
MCMCChains = "5, 6"
7575
NamedArrays = "0.9, 0.10"
76+
Optim = "1"
7677
Optimization = "3"
7778
OptimizationOptimJL = "0.1, 0.2, 0.3"
7879
OrderedCollections = "1"
7980
Printf = "1"
8081
Random = "1"
81-
Optim = "1"
8282
Reexport = "0.2, 1"
83-
Requires = "0.5, 1.0"
8483
SciMLBase = "2"
8584
SpecialFunctions = "0.7.2, 0.8, 0.9, 0.10, 1, 2"
8685
Statistics = "1.6"

src/Turing.jl

Lines changed: 1 addition & 20 deletions
Original file line numberDiff line numberDiff line change
@@ -107,6 +107,7 @@ export @model, # modelling
107107
AutoReverseDiff,
108108
AutoZygote,
109109
AutoTracker,
110+
AutoTapir,
110111
setprogress!, # debugging
111112
Flat,
112113
FlatPos,
@@ -136,24 +137,4 @@ export @model, # modelling
136137
MAP,
137138
MLE
138139

139-
# AutoTapir is only supported by ADTypes v1.0 and above.
140-
@static if VERSION >= v"1.10" && pkgversion(ADTypes) >= v"1"
141-
export AutoTapir
142-
end
143-
144-
if !isdefined(Base, :get_extension)
145-
using Requires
146-
end
147-
148-
function __init__()
149-
@static if !isdefined(Base, :get_extension)
150-
@require Optim = "429524aa-4258-5aef-a3af-852621145aeb" include(
151-
"../ext/TuringOptimExt.jl"
152-
)
153-
@require DynamicHMC = "bbc10e6e-7c05-544b-b16e-64fede858acb" include(
154-
"../ext/TuringDynamicHMCExt.jl"
155-
)
156-
end
157-
end
158-
159140
end

src/essential/Essential.jl

Lines changed: 2 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -11,7 +11,7 @@ using Bijectors: PDMatDistribution
1111
using AdvancedVI
1212
using StatsFuns: logsumexp, softmax
1313
@reexport using DynamicPPL
14-
using ADTypes: ADTypes, AutoForwardDiff, AutoTracker, AutoReverseDiff, AutoZygote
14+
using ADTypes: ADTypes, AutoForwardDiff, AutoTracker, AutoReverseDiff, AutoZygote, AutoTapir
1515

1616
using AdvancedPS: AdvancedPS
1717

@@ -23,13 +23,8 @@ export @model,
2323
AutoTracker,
2424
AutoZygote,
2525
AutoReverseDiff,
26+
AutoTapir,
2627
@logprob_str,
2728
@prob_str
2829

29-
# AutoTapir is only supported by ADTypes v1.0 and above.
30-
@static if VERSION >= v"1.10" && pkgversion(ADTypes) >= v"1"
31-
using ADTypes: AutoTapir
32-
export AutoTapir
33-
end
34-
3530
end # module

test/Project.toml

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -30,6 +30,7 @@ SpecialFunctions = "276daf66-3868-5448-9aa4-cd146d93841b"
3030
StableRNGs = "860ef19b-820b-49d6-a774-d7a799459cd3"
3131
StatsBase = "2913bbd2-ae8a-5f71-8c99-4fb6c76f3a91"
3232
StatsFuns = "4c63d2b9-4356-54db-8cca-17b64c39e42c"
33+
Tapir = "07d77754-e150-4737-8c94-cd238a1fb45b"
3334
Test = "8dfed614-e22c-5e08-85e1-65c5234f0b40"
3435
TimerOutputs = "a759f4b9-e2f1-59dc-863e-4aeb61b1ea8f"
3536
Tracker = "9f7883ad-71c0-57eb-9f7f-b5c9e6d3789c"
@@ -67,6 +68,7 @@ SpecialFunctions = "0.10.3, 1, 2"
6768
StableRNGs = "1"
6869
StatsBase = "0.33, 0.34"
6970
StatsFuns = "0.9.5, 1"
71+
Tapir = "0.2.45"
7072
TimerOutputs = "0.5"
7173
Tracker = "0.2.11"
7274
Zygote = "0.5.4, 0.6"

test/mcmc/Inference.jl

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -12,11 +12,10 @@ using LinearAlgebra: I
1212
import MCMCChains
1313
import Random
1414
import ReverseDiff
15+
import Tapir
1516
using Test: @test, @test_throws, @testset
1617
using Turing
1718

18-
ADUtils.install_tapir && import Tapir
19-
2019
@testset "Testing inference.jl with $adbackend" for adbackend in ADUtils.adbackends
2120
# Only test threading if 1.3+.
2221
if VERSION > v"1.2"

test/mcmc/abstractmcmc.jl

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -12,12 +12,11 @@ using LogDensityProblemsAD: LogDensityProblemsAD
1212
using Random: Random
1313
using ReverseDiff: ReverseDiff
1414
using StableRNGs: StableRNG
15+
import Tapir
1516
using Test: @test, @test_throws, @testset
1617
using Turing
1718
using Turing.Inference: AdvancedHMC
1819

19-
ADUtils.install_tapir && import Tapir
20-
2120
function initialize_nuts(model::Turing.Model)
2221
# Create a log-density function with an implementation of the
2322
# gradient so we ensure that we're using the same AD backend as in Turing.

test/mcmc/gibbs.jl

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -8,13 +8,12 @@ using Distributions: sample
88
using ForwardDiff: ForwardDiff
99
using Random: Random
1010
using ReverseDiff: ReverseDiff
11+
import Tapir
1112
using Test: @test, @testset
1213
using Turing
1314
using Turing: Inference
1415
using Turing.RandomMeasures: ChineseRestaurantProcess, DirichletProcess
1516

16-
ADUtils.install_tapir && import Tapir
17-
1817
@testset "Testing gibbs.jl with $adbackend" for adbackend in ADUtils.adbackends
1918
@testset "gibbs constructor" begin
2019
N = 500

test/mcmc/gibbs_conditional.jl

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -12,11 +12,10 @@ using ReverseDiff: ReverseDiff
1212
using StableRNGs: StableRNG
1313
using StatsBase: counts
1414
using StatsFuns: StatsFuns
15+
import Tapir
1516
using Test: @test, @testset
1617
using Turing
1718

18-
ADUtils.install_tapir && import Tapir
19-
2019
@testset "Testing gibbs conditionals.jl with $adbackend" for adbackend in ADUtils.adbackends
2120
Random.seed!(1000)
2221
rng = StableRNG(123)

test/mcmc/hmc.jl

Lines changed: 1 addition & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -2,7 +2,6 @@ module HMCTests
22

33
using ..Models: gdemo_default
44
using ..ADUtils: ADTypeCheckContext
5-
#using ..Models: gdemo
65
using ..NumericalTests: check_gdemo, check_numerical
76
import ..ADUtils
87
using Distributions: Bernoulli, Beta, Categorical, Dirichlet, Normal, Wishart, sample
@@ -15,11 +14,10 @@ using LinearAlgebra: I, dot, vec
1514
import Random
1615
using StableRNGs: StableRNG
1716
using StatsFuns: logistic
17+
import Tapir
1818
using Test: @test, @test_logs, @testset
1919
using Turing
2020

21-
ADUtils.install_tapir && import Tapir
22-
2321
@testset "Testing hmc.jl with $adbackend" for adbackend in ADUtils.adbackends
2422
# Set a seed
2523
rng = StableRNG(123)

test/mcmc/sghmc.jl

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -8,11 +8,10 @@ import ForwardDiff
88
using LinearAlgebra: dot
99
import ReverseDiff
1010
using StableRNGs: StableRNG
11+
import Tapir
1112
using Test: @test, @testset
1213
using Turing
1314

14-
ADUtils.install_tapir && import Tapir
15-
1615
@testset "Testing sghmc.jl with $adbackend" for adbackend in ADUtils.adbackends
1716
@testset "sghmc constructor" begin
1817
alg = SGHMC(; learning_rate=0.01, momentum_decay=0.1, adtype=adbackend)

0 commit comments

Comments
 (0)