Skip to content

Commit 9369050

Browse files
authored
[buildkite] Update S3 credential handling (#416)
* [buildkite] Update S3 credential handling We were alerted that our S3 credentials had leaked in a build that dumps the environment when it errors out [0]. Because `TuringTutorials` uses the same infrastructure as `SciMLBenchmarks`, we have to update things here as well. This PR rotates to a new key, and also wipes out the key in the environment during the build itself, so that sensitive values won't get written out in debugging information like that. [0] https://github.com/SciML/SciMLBenchmarksOutput/blob/8d80b1840228c63e8c6fdc597049211a8b916dea/markdown/DynamicalODE/single_pendulums.md * Churn `00_introduction.jmd`
1 parent 5071073 commit 9369050

File tree

4 files changed

+17
-11
lines changed

4 files changed

+17
-11
lines changed

.buildkite/build_tutorial.sh

Lines changed: 10 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,10 @@
1+
#!/bin/bash
2+
3+
set -euo pipefail
4+
5+
echo "--- Instantiate"
6+
julia --project=. -e 'using Pkg; Pkg.instantiate(); Pkg.build()'
7+
8+
# Run tutorial
9+
echo "+++ Run tutorial for ${1}"
10+
julia --project=. weave_tutorials.jl "${1}"
0 Bytes
Binary file not shown.

.buildkite/run_tutorial.yml

Lines changed: 6 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -15,8 +15,8 @@ steps:
1515
plugins:
1616
- staticfloat/cryptic#v2:
1717
variables:
18-
- BUILDKITE_S3_ACCESS_KEY_ID="U2FsdGVkX1/ckce1vUF8A17rHLxcAlAou4aokaeS8YL6omsA1Vq1IDZko5cL1Z+t"
19-
- BUILDKITE_S3_SECRET_ACCESS_KEY="U2FsdGVkX1+SPF81nkK7KQ64DsafSl0qq2iG7BsQs1xlTYEtZV3MqQl3l/NWaiocaEywZZFbAB5zpnKPD0xHTQ=="
18+
- BUILDKITE_S3_ACCESS_KEY_ID="U2FsdGVkX1+WPOr26vcEpOV6IfWQ/wwzUGjFRYux1AFtQjongCK2rnzySL6mkLdR"
19+
- BUILDKITE_S3_SECRET_ACCESS_KEY="U2FsdGVkX19cbtDEWMwL+gpAtByCS8SJzX0hZ6qZ68L2bfjgAWJhbkb14T9uNwJZgKzWymvy0G9LwnJD/0VQ+Q=="
2020
- BUILDKITE_S3_DEFAULT_REGION="U2FsdGVkX1/cORlxhXcxhja2JkqC0f8RmaGYxvGBbEg="
2121
- JuliaCI/julia#v1:
2222
version: 1
@@ -44,20 +44,16 @@ steps:
4444
s3_prefix: s3://julialang-buildkite-artifacts/turingtutorials
4545
timeout_in_minutes: 360
4646
commands: |
47-
# Instantiate, to install the overall project dependencies
48-
echo "--- Instantiate"
49-
julia --project=. -e 'using Pkg; Pkg.instantiate(); Pkg.build()'
50-
# Run tutorial
51-
echo "+++ Run tutorial for {PATH}"
52-
julia --project=. weave_tutorials.jl "{PATH}"
47+
# We don't need these secrets at this point, so clear them out so they don't show up in debugging outputs
48+
BUILDKITE_S3_ACCESS_KEY_ID="" BUILDKITE_S3_SECRET_ACCESS_KEY="" ./.buildkite/build_tutorial.sh {PATH}
5349
- label: ":rocket: Publish {PATH}"
5450
env:
5551
BUILDKITE_PLUGIN_CRYPTIC_BASE64_SIGNED_JOB_ID_SECRET: ${BUILDKITE_PLUGIN_CRYPTIC_BASE64_SIGNED_JOB_ID_SECRET?}
5652
plugins:
5753
- staticfloat/cryptic#v2:
5854
variables:
59-
- BUILDKITE_S3_ACCESS_KEY_ID="U2FsdGVkX1/ckce1vUF8A17rHLxcAlAou4aokaeS8YL6omsA1Vq1IDZko5cL1Z+t"
60-
- BUILDKITE_S3_SECRET_ACCESS_KEY="U2FsdGVkX1+SPF81nkK7KQ64DsafSl0qq2iG7BsQs1xlTYEtZV3MqQl3l/NWaiocaEywZZFbAB5zpnKPD0xHTQ=="
55+
- BUILDKITE_S3_ACCESS_KEY_ID="U2FsdGVkX1+WPOr26vcEpOV6IfWQ/wwzUGjFRYux1AFtQjongCK2rnzySL6mkLdR"
56+
- BUILDKITE_S3_SECRET_ACCESS_KEY="U2FsdGVkX19cbtDEWMwL+gpAtByCS8SJzX0hZ6qZ68L2bfjgAWJhbkb14T9uNwJZgKzWymvy0G9LwnJD/0VQ+Q=="
6157
- BUILDKITE_S3_DEFAULT_REGION="U2FsdGVkX1/cORlxhXcxhja2JkqC0f8RmaGYxvGBbEg="
6258
files:
6359
- .buildkite/ssh_deploy.key

tutorials/00-introduction/00_introduction.jmd

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -179,7 +179,7 @@ rand(coinflip(; N))
179179
```
180180

181181
The model can be conditioned on some observations with `|`.
182-
See the [documentation of the `condition` syntax](https://turinglang.github.io/DynamicPPL.jl/stable/api/#Condition-and-decondition) in DynamicPPL.jl for more details.
182+
See the [documentation of the `condition` syntax](https://turinglang.github.io/DynamicPPL.jl/stable/api/#Condition-and-decondition) in `DynamicPPL.jl` for more details.
183183
In the conditioned `model` the observations `y` are fixed to `data`.
184184

185185
```julia

0 commit comments

Comments
 (0)