This repository was archived by the owner on May 1, 2025. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 56
original version removed still with cleanup false in configuration #134
Copy link
Copy link
Open
Description
original version removed still with cleanup false in configuration
Still when the configuration is like in the example:
cleanup: { versions: true, original: false },
the original version is removed, if I remove this cleanup element from the configuration the system keeps everything (original and versions) But it was impossible for me to keep only the original.
I'm using node 7.4.
Your environment
- Operating system
- Mac
- Windows
- Linux
- Node.js version (
node --version)- Node.js v4.x
- Node.js v7.4
- ImageMagick version (
identify -version)- ImageMagick v6.9.x
- ImageMagick v7.0.x
- s3-uploader version
- v0.x
- v1.x
- v2.x
Steps to reproduce
I basically use a very similar code from the example provided
var clientS3Options = {
aws: {
path: '',
region: 'eu-west-1',
acl: 'public-read',
accessKeyId: 'XXX',
secretAccessKey: 'XXX',
endpoint: 'https://s3-eu-west-1.amazonaws.com',
},
cleanup: {
versions: true,
original: false
},
versions: [{
maxWidth: 960,
format: 'jpg',
quality: 80
},{
maxWidth: 960,
format: 'jpg',
suffix: '@3x',
quality: 80
},{
maxWidth: 640,
format: 'jpg',
suffix: '@2x',
quality: 80
},{
maxWidth: 320,
format: 'jpg',
suffix: '@1x',
quality: 80
}]
};Expected behaviour
I expect to keep the original version and remove the versions one from the source after upload the images to S3
Actual behaviour
the original version is removed, if I remove this cleanup element from the configuration the system keeps everything (original and versions) But it was impossible for me to keep only the original.
Reactions are currently unavailable
Metadata
Metadata
Assignees
Labels
No labels