Skip to content

Commit caaf787

Browse files
author
games647
committed
Clarify index usage
1 parent 0e8990a commit caaf787

File tree

2 files changed

+6
-4
lines changed

2 files changed

+6
-4
lines changed

Cargo.toml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -61,7 +61,7 @@ features = ["std"]
6161
[dependencies.clap]
6262
version = "3.0.0-beta.2"
6363

64-
# Disable suggesttions feature
64+
# Disable suggestions feature
6565
default-features = false
6666
features = ["color", "derive", "std", "cargo"]
6767

README.md

Lines changed: 5 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -4,8 +4,8 @@
44

55
Small application to scan exported passwords from your password storage against the offline hash database from
66
[haveibeenpwned](https://haveibeenpwned.com) in order to verify if any passwords are exposed. It includes many
7-
performance features, making the scan very fast **without needing any intermediate conversion** of the original hash
8-
database file. Using that it would make it even faster (See [Index](#Index)).
7+
performance features, making the scan very fast **without needing any index or intermediate conversion** of the
8+
original hash database file. Using that it would make it even faster (See [Index](#Index)) for multiple runs.
99

1010
This project is also intended for learning Rust (incl. parallelism with channel communication) and its ecosystem.
1111
Feedback appreciated.
@@ -28,6 +28,7 @@ Feedback appreciated.
2828
* Read hash database from ASCII
2929
* Re-use allocations if possible - for example database reading only uses borrowed data
3030
* `fadvise` and `madvise` for UNIX based systems
31+
* Lazily parse the count column in the database
3132

3233
### Design
3334

@@ -154,7 +155,8 @@ All this requires benchmarking first.
154155

155156
This tool is specifically designed for individuals. So the main use case is to do only a single run. There are tools
156157
like [csv-index](https://docs.rs/csv-index/) that could create an intermediate index over the data. This could be useful
157-
for concurrent access to the file.
158+
for concurrent access to the file or random file access than reading it sequential. However, it then takes additional
159+
time and space to calculate this index.
158160

159161
### Binary searching
160162

0 commit comments

Comments
 (0)