Merge pull request #47 from YannickJadoul/lazy-fixture-param-ids

Adding pytest_make_parametrize_id implementation to get better default ids for lazy fixtures

Author: TvoroG

pytest_lazyfixture.py

@@ -62,6 +62,11 @@ def pytest_pycollect_makeitem(collector, name, obj):
     current_node = None
 
 
+def pytest_make_parametrize_id(config, val, argname):
+    if is_lazy_fixture(val):
+        return val.name
+
+
 @pytest.hookimpl(hookwrapper=True)
 def pytest_generate_tests(metafunc):
     yield

tests/test_lazyfixture.py

@@ -878,3 +878,29 @@ def test_bug(value):
     """)
     result = testdir.inline_run('-s')
     result.assertoutcome(passed=2)
+
+
+# https://github.com/TvoroG/pytest-lazy-fixture/issues/46
+def test_lazy_fixture_ids(testdir):
+    testdir.makepyfile("""
+        import pytest
+        from pytest_lazyfixture import lazy_fixture
+
+        @pytest.fixture()
+        def foo():
+            return "foo"
+
+        @pytest.fixture(params=['spam', 'eggs'])
+        def bar(request):
+            return "bar-{}".format(request.param)
+
+        @pytest.mark.parametrize("data", [lazy_fixture("foo"),
+                                          lazy_fixture("bar")])
+        def test_the_thing(data):
+            assert False
+    """)
+    result = testdir.runpytest('--collect-only')
+    stdout = result.stdout.str()
+    assert 'test_the_thing[foo]' in stdout
+    assert 'test_the_thing[bar-spam]' in stdout
+    assert 'test_the_thing[bar-eggs]' in stdout