Fix/OpenSky: Response to wrong secret changed

Author: TwinFan

Src/LTOpenSky.cpp

@@ -265,19 +265,22 @@ bool OpenSkyConnection::ProcessFetchedData ()
             break;
 
         // Unauthorized? Also wrong token, or wrong credentials when trying to get the token
-        case HTTP_BAD_REQUEST:      // OpenSky returns 400 in case of bad credentials when asking for the token...a bit weird, but so it is
-            SHOW_MSG(logERR, "%s: Authorization failed! Verify Client Id/Secret in settings.",
-                     pszChName);
-            SetValid(false,false);
-            SetEnable(false);       // also disable to directly allow user/pwd change...and won't work on retry anyway
-            return false;
-
+        case HTTP_BAD_REQUEST:      // OpenSky had returned 400 in case of bad credentials when asking for the token...seems it does no longer, but we handled it still
         case HTTP_UNAUTHORIZED:     // OpenSky returns 401 in case of a bad or timed-out token
-            LOG_MSG(logERR, "%s: Bad or timed-out access token",
-                    pszChName);
-            ResetStatus();          // let's try with a new one
-            IncErrCnt();
-            return false;
+            if (eState == OPSKY_STATE_GETTING_TOKEN) {
+                SHOW_MSG(logERR, "%s: Authorization failed! Verify Client Id/Secret in settings.",
+                         pszChName);
+                SetValid(false,false);
+                SetEnable(false);       // also disable to directly allow user/pwd change...and won't work on retry anyway
+                return false;
+            }
+            else {
+                LOG_MSG(logERR, "%s: Bad or timed-out access token",
+                        pszChName);
+                ResetStatus();          // let's try with a new one
+                IncErrCnt();
+                return false;
+            }
 
         // Ran out of requests?
         case HTTP_TOO_MANY_REQU:

docs/readme.html

@@ -153,7 +153,7 @@ <h3>v4.2.1</h3>
                     As a registered OpenSky user who wants to use up to 4000 request per day,
                     you now need to optain a "Client ID" and "Client Secret" from
                     <a href="https://opensky-network.org/my-opensky/account">your OpenSky account page</a>
-                    and enter those into LiveTraffic's settings.<br>
+                    and load or enter those into LiveTraffic's settings.<br>
                     For more details <a href="https://twinfan.gitbook.io/livetraffic/setup/installation/opensky">see the documentation</a>.
                 </li>
                 <li>