Raise an ArgumentError if given an empty ical string

Author: John Crepezzi

lib/ice_cube/parsers/ical_parser.rb

@@ -24,6 +24,8 @@ def self.schedule_from_ical(ical_string, options = {})
     end
 
     def self.rule_from_ical(ical)
+      raise ArgumentError, 'empty ical rule' if ical.nil?
+
       validations = {}
       params = {validations: validations, interval: 1}
 

spec/examples/from_ical_spec.rb

@@ -385,6 +385,21 @@ def sorted_ical(ical)
         schedule.recurrence_rules.count.should == 2
       end
     end
+
+    describe 'invalid ical data' do
+      shared_examples_for('an invalid ical string') do
+        it do
+          expect {
+            IceCube::Schedule.from_ical(ical_str)
+          }.to raise_error(ArgumentError) # TODO replace with real ad
+        end
+      end
+
+      describe 'empty rules' do
+        let(:ical_str) { 'RRULE::' }
+        it_behaves_like 'an invalid ical string'
+      end
+    end
   end
 
 end