Skip to content

Commit 6bda692

Browse files
committed
Support passing RAILS_VERSION for development
Move dynamic development dependencies to Gemfile
1 parent ba34f0d commit 6bda692

File tree

3 files changed

+11
-4
lines changed

3 files changed

+11
-4
lines changed

Gemfile

Lines changed: 9 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,3 +1,11 @@
11
source 'https://rubygems.org'
2+
gemspec
23

3-
gemspec
4+
compatible_rails_versions = [
5+
'>= 3.0.0',
6+
('<5' if Gem::Version.new(RUBY_VERSION) < Gem::Version.new('2.2.2'))
7+
].compact
8+
9+
gem 'activesupport', (ENV['RAILS_VERSION'] || compatible_rails_versions), require: false
10+
gem 'i18n', require: false
11+
gem 'tzinfo', require: false # only needed explicitly for RAILS_VERSION=3

ice_cube.gemspec

Lines changed: 0 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -19,7 +19,4 @@ Gem::Specification.new do |s|
1919

2020
s.add_development_dependency('rake')
2121
s.add_development_dependency('rspec', '~> 2.12.0')
22-
s.add_development_dependency('activesupport', ['>= 3.0.0', ('<5' if Gem::Version.new(RUBY_VERSION) < Gem::Version.new('2.2.2'))].compact)
23-
s.add_development_dependency('tzinfo')
24-
s.add_development_dependency('i18n')
2522
end

spec/examples/active_support_spec.rb

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,7 @@
11
require File.dirname(__FILE__) + '/../spec_helper'
22
require 'active_support/time'
3+
require 'active_support/version'
4+
require 'tzinfo' if ActiveSupport::VERSION::MAJOR == 3
35

46

57
module IceCube

0 commit comments

Comments
 (0)