fix linter issues

Author: pvormste

openapi3/issue230_test.go

@@ -6,6 +6,7 @@ import (
 	"testing"
 
 	"github.com/getkin/kin-openapi/openapi3"
+	"github.com/stretchr/testify/assert"
 	"github.com/stretchr/testify/require"
 )
 
@@ -495,18 +496,14 @@ func TestMigrationScenarios(t *testing.T) {
 		var doc30 openapi3.T
 		err := json.Unmarshal(spec30, &doc30)
 		require.NoError(t, err)
-
-		if doc30.IsOpenAPI3_1() {
-		}
+		assert.False(t, doc30.IsOpenAPI3_1())
 
 		// Simulate loading 3.1 document
 		spec31 := []byte(`{"openapi":"3.1.0","info":{"title":"Test","version":"1.0.0"},"paths":{}}`)
 		var doc31 openapi3.T
 		err = json.Unmarshal(spec31, &doc31)
 		require.NoError(t, err)
-
-		if doc31.IsOpenAPI3_1() {
-		}
+		assert.True(t, doc31.IsOpenAPI3_1())
 
 		// Cleanup
 	})
@@ -539,11 +536,13 @@ func TestEdgeCases(t *testing.T) {
 		}
 
 		// Nil webhooks should not serialize
-		data30, _ := json.Marshal(doc30)
+		data30, err := json.Marshal(doc30)
+		require.NoError(t, err)
 		require.NotContains(t, string(data30), "webhooks")
 
 		// Empty webhooks should not serialize
-		data31, _ := json.Marshal(doc31Empty)
+		data31, err := json.Marshal(doc31Empty)
+		require.NoError(t, err)
 		require.NotContains(t, string(data31), "webhooks")
 	})
 

openapi3/schema.go

@@ -2323,11 +2323,11 @@ func markSchemaErrorKey(err error, key string) error {
 		v.reversePath = append(v.reversePath, key)
 		if v.Origin != nil {
 			if unwrapped := errors.Unwrap(v.Origin); unwrapped != nil {
-				if me, ok := unwrapped.(multiErrorForOneOf); ok {
-					_ = markSchemaErrorKey(MultiError(me), key)
+				if me, ok := unwrapped.(multiErrorForOneOf); ok { //nolint:errorlint
+					_ = markSchemaErrorKey(MultiError(me), key) //nolint:errcheck
 				}
-				if me, ok := unwrapped.(multiErrorForAllOf); ok {
-					_ = markSchemaErrorKey(MultiError(me), key)
+				if me, ok := unwrapped.(multiErrorForAllOf); ok { //nolint:errorlint
+					_ = markSchemaErrorKey(MultiError(me), key) //nolint:errcheck
 				}
 			}
 		}

openapi3filter/req_resp_decoder_test.go

@@ -1683,16 +1683,19 @@ func TestDecodeBody(t *testing.T) {
 		{name: "f", contentType: "application/json", data: strings.NewReader(`{"foo1": "foo1"}`), filename: "f1"},
 		{name: "f", contentType: "application/pdf", data: strings.NewReader("foo2"), filename: "f2"},
 	})
+	require.NoError(t, err)
 
 	multipartBinaryEncodingCTUnsupported, multipartMimeBinaryEncodingCTUnsupported, err := newTestMultipartForm([]*testFormPart{
 		{name: "b", contentType: "application/json", data: strings.NewReader(`{"bar1": "bar1"}`), filename: "b1"},
 		{name: "d", contentType: "application/pdf", data: strings.NewReader("doo1"), filename: "d1"},
 	})
+	require.NoError(t, err)
 
 	multipartBinaryEncodingCTNotMatching, multipartMimeBinaryEncodingCTNotMatching, err := newTestMultipartForm([]*testFormPart{
 		{name: "b", contentType: "application/json", data: strings.NewReader(`{"bar1": "bar1"}`), filename: "b1"},
 		{name: "d", contentType: "application/pdf", data: strings.NewReader("doo1"), filename: "d1"},
 	})
+	require.NoError(t, err)
 
 	testCases := []struct {
 		name     string