Merge pull request #14 from Tynamix/FEATURE_BetterLogging

Tynamix · Tynamix · commit 3c49c7724888 · 2014-06-02T22:01:11.000+02:00
Logging each exception msg to Debug.WriteLine before throwing. Simplifie...
diff --git a/ObjectFiller/Filler.cs b/ObjectFiller/Filler.cs
@@ -2,6 +2,7 @@
 using System.Collections;
 using System.Collections.Generic;
 using System.Configuration;
+using System.Diagnostics;
 using System.Globalization;
 using System.Linq;
 using System.Reflection;
@@ -123,8 +124,9 @@ private object CreateInstanceOfType(Type type, ObjectFillerSetup currentSetup)
 
                     if (constructorArgs.Count == 0)
                     {
-                        throw new InvalidOperationException("Could not found a constructor for type [" + type.Name +
-                                                            "] where the parameters can be filled with the current objectfiller setup");
+	                    var message = "Could not found a constructor for type [" + type.Name + "] where the parameters can be filled with the current objectfiller setup";
+						Debug.WriteLine("ObjectFiller: " + message);
+	                    throw new InvalidOperationException(message);
                     }
                 }
             }
@@ -316,13 +318,12 @@ private IDictionary GetFilledDictionary(Type propertyType, ObjectFillerSetup cur
 
                 if (dictionary.Contains(keyObject))
                 {
-                    throw new ArgumentException(
-                        string.Format(
-                            "Generating Keyvalue failed because it generates always the same data for type [{0}]. Please check your setup.",
-                            keyType));
+	                string message = string.Format("Generating Keyvalue failed because it generates always the same data for type [{0}]. Please check your setup.", keyType);
+					Debug.WriteLine("ObjectFiller: " + message);
+	                throw new ArgumentException(message);
                 }
 
-                object valueObject = GetFilledObject(valueType, currentSetup);
+	            object valueObject = GetFilledObject(valueType, currentSetup);
                 dictionary.Add(keyObject, valueObject);
             }
             return dictionary;
@@ -382,12 +383,12 @@ private object GetInterfaceInstance(Type interfaceType, ObjectFillerSetup setup)
             {
                 if (setup.InterfaceMocker == null)
                 {
-                    throw new InvalidOperationException(
-                        string.Format("ObjectFiller Interface mocker missing and type [{0}] not registered",
-                                      interfaceType.Name));
+	                string message = string.Format("ObjectFiller Interface mocker missing and type [{0}] not registered", interfaceType.Name);
+					Debug.WriteLine("ObjectFiller: " + message);
+	                throw new InvalidOperationException(message);
                 }
 
-                MethodInfo method = setup.InterfaceMocker.GetType().GetMethod("Create");
+	            MethodInfo method = setup.InterfaceMocker.GetType().GetMethod("Create");
                 MethodInfo genericMethod = method.MakeGenericMethod(new[] { interfaceType });
                 result = genericMethod.Invoke(setup.InterfaceMocker, null);
             }
@@ -402,7 +403,9 @@ private object GetRandomValue(Type propertyType, ObjectFillerSetup setup)
                 return setup.TypeToRandomFunc[propertyType]();
             }
 
-            throw new TypeInitializationException(propertyType.FullName, new Exception("The type [" + propertyType.Name + "] was not registered in the randomizer."));
+	        string message = "The type [" + propertyType.Name + "] was not registered in the randomizer.";
+			Debug.WriteLine("ObjectFiller: " + message);
+	        throw new TypeInitializationException(propertyType.FullName, new Exception(message));
         }
 
         private static bool TypeIsValidForObjectFiller(Type type, ObjectFillerSetup currentSetup)
diff --git a/ObjectFiller/Plugins/EnumeratorPlugin.cs b/ObjectFiller/Plugins/EnumeratorPlugin.cs
@@ -1,5 +1,6 @@
 using System;
 using System.Collections.Generic;
+using System.Diagnostics;
 
 namespace Tynamix.ObjectFiller
 {
@@ -31,7 +32,9 @@ public T GetValue()
 
                 if (!hasNext)
                 {
-                    throw new Exception("Unable to get next value from enumeration " + _enumerable);
+	                string message = "Unable to get next value from enumeration " + _enumerable;
+					Debug.WriteLine("ObjectFiller: " + message);
+					throw new Exception(message);
                 }
             }
 
diff --git a/ObjectFiller/Plugins/RandomListItem.cs b/ObjectFiller/Plugins/RandomListItem.cs
@@ -1,5 +1,6 @@
 ﻿using System;
 using System.Collections.Generic;
+using System.Diagnostics;
 
 namespace Tynamix.ObjectFiller
 {
@@ -11,9 +12,11 @@ public RandomListItem(List<T> allAvailableValues)
         {
             if (allAvailableValues == null || allAvailableValues.Count == 0)
             {
-                throw new ArgumentException("List in RandomListItem ranomizer can not be empty!");
+	            const string message = "List in RandomListItem ranomizer can not be empty!";
+				Debug.WriteLine("ObjectFiller: " + message);
+				throw new ArgumentException(message);
             }
-            _allAvailableValues = allAvailableValues;
+	        _allAvailableValues = allAvailableValues;
 
         }
 
diff --git a/ObjectFiller/Plugins/String/PatternGenerator.cs b/ObjectFiller/Plugins/String/PatternGenerator.cs
@@ -251,6 +251,9 @@ private static char NextChar(char charClass)
 				if (charClass == 'A') return NextUpperCaseChar();
 				if (charClass == 'N') return NextDecimalDigit();
 				if (charClass == 'X') return NextHexDigit();
+
+				var message = "Unexpected character class: " + charClass;
+				Debug.WriteLine("ObjectFiller: " + message);
 				throw new InvalidOperationException();
 			}
 
diff --git a/ObjectFiller/Setup/FluentFillerApi.cs b/ObjectFiller/Setup/FluentFillerApi.cs
@@ -1,5 +1,6 @@
 using System;
 using System.Collections.Generic;
+using System.Diagnostics;
 using System.Linq.Expressions;
 using System.Reflection;
 
@@ -114,9 +115,11 @@ public FluentFillerApi<TTargetObject> SetInterfaceMocker(IInterfaceMocker mocker
         {
             if (SetupManager.GetFor<TTargetObject>().InterfaceMocker != null)
             {
-                throw new ArgumentException("You can not set a interface mocker more than once!");
+	            const string message = "You can not set a interface mocker more than once!";
+				Debug.WriteLine("ObjectFiller: " + message);
+				throw new ArgumentException(message);
             }
-            SetupManager.GetFor<TTargetObject>().InterfaceMocker = mocker;
+	        SetupManager.GetFor<TTargetObject>().InterfaceMocker = mocker;
             return this;
         }
 

Original file line number	Diff line number	Diff line change
`@@ -2,6 +2,7 @@`
`2`	`2`	`using System.Collections;`
`3`	`3`	`using System.Collections.Generic;`
`4`	`4`	`using System.Configuration;`
	`5`	`+using System.Diagnostics;`
`5`	`6`	`using System.Globalization;`
`6`	`7`	`using System.Linq;`
`7`	`8`	`using System.Reflection;`
`@@ -123,8 +124,9 @@ private object CreateInstanceOfType(Type type, ObjectFillerSetup currentSetup)`
`123`	`124`
`124`	`125`	`if (constructorArgs.Count == 0)`
`125`	`126`	`{`
`126`		`- throw new InvalidOperationException("Could not found a constructor for type [" + type.Name +`
`127`		`- "] where the parameters can be filled with the current objectfiller setup");`
	`127`	`+ var message = "Could not found a constructor for type [" + type.Name + "] where the parameters can be filled with the current objectfiller setup";`
	`128`	`+ Debug.WriteLine("ObjectFiller: " + message);`
	`129`	`+ throw new InvalidOperationException(message);`
`128`	`130`	`}`
`129`	`131`	`}`
`130`	`132`	`}`
`@@ -316,13 +318,12 @@ private IDictionary GetFilledDictionary(Type propertyType, ObjectFillerSetup cur`
`316`	`318`
`317`	`319`	`if (dictionary.Contains(keyObject))`
`318`	`320`	`{`
`319`		`- throw new ArgumentException(`
`320`		`- string.Format(`
`321`		`- "Generating Keyvalue failed because it generates always the same data for type [{0}]. Please check your setup.",`
`322`		`- keyType));`
	`321`	`+ string message = string.Format("Generating Keyvalue failed because it generates always the same data for type [{0}]. Please check your setup.", keyType);`
	`322`	`+ Debug.WriteLine("ObjectFiller: " + message);`
	`323`	`+ throw new ArgumentException(message);`
`323`	`324`	`}`
`324`	`325`
`325`		`- object valueObject = GetFilledObject(valueType, currentSetup);`
	`326`	`+ object valueObject = GetFilledObject(valueType, currentSetup);`
`326`	`327`	`dictionary.Add(keyObject, valueObject);`
`327`	`328`	`}`
`328`	`329`	`return dictionary;`
`@@ -382,12 +383,12 @@ private object GetInterfaceInstance(Type interfaceType, ObjectFillerSetup setup)`
`382`	`383`	`{`
`383`	`384`	`if (setup.InterfaceMocker == null)`
`384`	`385`	`{`
`385`		`- throw new InvalidOperationException(`
`386`		`- string.Format("ObjectFiller Interface mocker missing and type [{0}] not registered",`
`387`		`- interfaceType.Name));`
	`386`	`+ string message = string.Format("ObjectFiller Interface mocker missing and type [{0}] not registered", interfaceType.Name);`
	`387`	`+ Debug.WriteLine("ObjectFiller: " + message);`
	`388`	`+ throw new InvalidOperationException(message);`
`388`	`389`	`}`
`389`	`390`
`390`		`- MethodInfo method = setup.InterfaceMocker.GetType().GetMethod("Create");`
	`391`	`+ MethodInfo method = setup.InterfaceMocker.GetType().GetMethod("Create");`
`391`	`392`	`MethodInfo genericMethod = method.MakeGenericMethod(new[] { interfaceType });`
`392`	`393`	`result = genericMethod.Invoke(setup.InterfaceMocker, null);`
`393`	`394`	`}`
`@@ -402,7 +403,9 @@ private object GetRandomValue(Type propertyType, ObjectFillerSetup setup)`
`402`	`403`	`return setup.TypeToRandomFunc[propertyType]();`
`403`	`404`	`}`
`404`	`405`
`405`		`- throw new TypeInitializationException(propertyType.FullName, new Exception("The type [" + propertyType.Name + "] was not registered in the randomizer."));`
	`406`	`+ string message = "The type [" + propertyType.Name + "] was not registered in the randomizer.";`
	`407`	`+ Debug.WriteLine("ObjectFiller: " + message);`
	`408`	`+ throw new TypeInitializationException(propertyType.FullName, new Exception(message));`
`406`	`409`	`}`
`407`	`410`
`408`	`411`	`private static bool TypeIsValidForObjectFiller(Type type, ObjectFillerSetup currentSetup)`
Original file line number	Diff line number	Diff line change
`@@ -1,5 +1,6 @@`
`1`	`1`	`using System;`
`2`	`2`	`using System.Collections.Generic;`
	`3`	`+using System.Diagnostics;`
`3`	`4`
`4`	`5`	`namespace Tynamix.ObjectFiller`
`5`	`6`	`{`
`@@ -31,7 +32,9 @@ public T GetValue()`
`31`	`32`
`32`	`33`	`if (!hasNext)`
`33`	`34`	`{`
`34`		`- throw new Exception("Unable to get next value from enumeration " + _enumerable);`
	`35`	`+ string message = "Unable to get next value from enumeration " + _enumerable;`
	`36`	`+ Debug.WriteLine("ObjectFiller: " + message);`
	`37`	`+ throw new Exception(message);`
`35`	`38`	`}`
`36`	`39`	`}`
`37`	`40`
Original file line number	Diff line number	Diff line change
`@@ -251,6 +251,9 @@ private static char NextChar(char charClass)`
`251`	`251`	`if (charClass == 'A') return NextUpperCaseChar();`
`252`	`252`	`if (charClass == 'N') return NextDecimalDigit();`
`253`	`253`	`if (charClass == 'X') return NextHexDigit();`
	`254`	`+`
	`255`	`+ var message = "Unexpected character class: " + charClass;`
	`256`	`+ Debug.WriteLine("ObjectFiller: " + message);`
`254`	`257`	`throw new InvalidOperationException();`
`255`	`258`	`}`
`256`	`259`