Fix LoadRequest empty temporary file existence issue

Update Shard.Requests to 2.1.6

Author: Meyn

DownloadAssistant/DownloadAssistant.csproj

@@ -10,7 +10,7 @@
     <PackageProjectUrl></PackageProjectUrl>
     <PackageIcon>logo.png</PackageIcon>
     <PackageReadmeFile>README.md</PackageReadmeFile>
-    <Version>1.0.3</Version>
+    <Version>1.0.4</Version>
     <GenerateDocumentationFile>True</GenerateDocumentationFile>
     <Description>A free to use library as a download manager.
 Includes retry, priority, cancel, etc.. function.
@@ -26,9 +26,8 @@ Features:
     <PackageRequireLicenseAcceptance>True</PackageRequireLicenseAcceptance>
     <Company>Shard</Company>
     <Authors>Meyn</Authors>
-    <PackageReleaseNotes>Implement WriteMode.AppendOrTruncate
-Implement RequestFailed to LoadRequest
-Implement Download Speed Measurement</PackageReleaseNotes>
+    <PackageReleaseNotes>Fix LoadRequest empty temporary file existence issue
+Update Shard.Requests to 2.1.6</PackageReleaseNotes>
     <RepositoryUrl>https://github.com/TypNull/DownloadAssistant</RepositoryUrl>
   </PropertyGroup>
 
@@ -48,7 +47,7 @@ Implement Download Speed Measurement</PackageReleaseNotes>
   </ItemGroup>
 
   <ItemGroup>
-    <PackageReference Include="Shard.Requests" Version="2.1.4" />
+    <PackageReference Include="Shard.Requests" Version="2.1.6" />
   </ItemGroup>
 
   <ItemGroup>

DownloadAssistant/Requests/GetRequest.cs

@@ -123,6 +123,7 @@ private void LoadWrittenBytes()
             FilePath = Path.Combine(Options.DirectoryPath, Filename);
             if (File.Exists(FilePath))
                 BytesWritten = new FileInfo(FilePath).Length;
+            BytesWritten = BytesWritten == 0 ? -1 : BytesWritten;
         }
 
         /// <summary>
@@ -386,8 +387,6 @@ private async Task WriterAsync(ThrottledStream responseStream, FileStream fileSt
         /// <returns><c>true</c> if the file should be deleted; otherwise, <c>false</c>.</returns>
         private bool CheckClearFile(bool noBytesWritten) => ((!IsPartial()) && ShouldBePartial() && BytesWritten > 0) || (noBytesWritten && BytesWritten < Options.MinReloadSize);
 
-
-
         /// <summary>
         /// Disposes the <see cref="GetRequest"/> instance.
         /// </summary>

DownloadAssistant/Requests/LoadRequest.cs

@@ -245,7 +245,7 @@ private void OnStateChanged(object? sender, RequestState state)
         private void OnFailure(IRequest? request, HttpResponseMessage? element)
         {
             State = RequestState.Failed;
-            Pause();
+            Cancel();
             _ = ClearOnFailure();
             SynchronizationContext.Post((object? o) => Options.RequestFailed?.Invoke((IRequest)o!, element), this);
         }
@@ -314,13 +314,18 @@ private void CreatePlaceholderFile(GetRequest request)
                     _writeMode = WriteMode.AppendOrTruncate;
                     break;
                 case WriteMode.Overwrite:
-                case WriteMode.AppendOrTruncate:
                     IOManager.Create(Destination);
 
+                    _writeMode = WriteMode.AppendOrTruncate;
+                    break;
+                case WriteMode.AppendOrTruncate:
+                    if (!File.Exists(Destination) || new FileInfo(Destination).Length <= 0)
+                        break;
+                    IOManager.Create(Destination);
                     _writeMode = WriteMode.AppendOrTruncate;
                     break;
                 case WriteMode.Append:
-                    if (!File.Exists(Destination) && new FileInfo(Destination).Length <= 0)
+                    if (!File.Exists(Destination) || new FileInfo(Destination).Length <= 0)
                         break;
                     AddException(new FileLoadException($"The file {Filename} at {Destination} already exists. Please change the WriteMode to Create or increase the MinReloadSize."));
                     OnFailure(this, null);
@@ -454,13 +459,12 @@ private async Task ClearOnFailure()
                     File.Delete(TempDestination);
                 if (File.Exists(Destination) && new FileInfo(Destination).Length == 0)
                     File.Delete(Destination);
-                await _chunkHandler.DeleteChunkFiles(_chunkHandler.RequestContainer.Length);
+                await _chunkHandler.DeleteChunkFiles(_chunkHandler.RequestContainer.Count);
             }
             catch (Exception ex)
             {
                 AddException(ex);
             }
-
         }
 
         /// <summary>