Fix path check for UNIX systems in LoadRequest

Author: Meyn

DownloadAssistant/DownloadAssistant.csproj

@@ -6,11 +6,11 @@
     <Nullable>enable</Nullable>
     <Title>DownloadAssistant</Title>
     <PackageId>Shard.DownloadAssistant</PackageId>
-    <Copyright>Shard © 2024</Copyright>
+    <Copyright>Shard © 2025</Copyright>
     <PackageProjectUrl></PackageProjectUrl>
     <PackageIcon>logo.png</PackageIcon>
     <PackageReadmeFile>README.md</PackageReadmeFile>
-    <Version>1.0.6</Version>
+    <Version>1.0.7</Version>
     <GenerateDocumentationFile>True</GenerateDocumentationFile>
     <Description>A free to use library as a download manager.
 Includes retry, priority, cancel, etc.. function.
@@ -26,13 +26,7 @@ Features:
     <PackageRequireLicenseAcceptance>True</PackageRequireLicenseAcceptance>
     <Company>Shard</Company>
     <Authors>Meyn</Authors>
-    <PackageReleaseNotes>Implement InterceptCompletionAsync for GetRequest.
-Fix SubsequentRequest functionality in LoadRequest.
-Resolve file information parsing issues in GetRequest partial downloads.
-Fix exception handling for Append mode in LoadRequest.
-Address chunk merging issues in LoadRequest.
-Update `Shard.Requests` to version 2.2.1.
-Update unit tests</PackageReleaseNotes>
+    <PackageReleaseNotes>Fix path check for UNIX systems in LoadRequest</PackageReleaseNotes>
     <RepositoryUrl>https://github.com/TypNull/DownloadAssistant</RepositoryUrl>
   </PropertyGroup>
 

DownloadAssistant/Utilities/IOManager.cs

@@ -13,7 +13,7 @@ internal static class IOManager
         /// <summary>
         /// Array of characters that are not allowed in file names.
         /// </summary>
-        public static char[] InvalidFileNameChars = new char[]
+        public static char[] InvalidFileNameCharsWindows = new char[]
           {
             '\"', '<', '>', '|', '\0',
             (char)1, (char)2, (char)3, (char)4, (char)5, (char)6, (char)7, (char)8, (char)9, (char)10,
@@ -22,6 +22,8 @@ internal static class IOManager
             (char)31, ':', '?', '\\', '/'
           };
 
+        public static char[] InvalidFileNameCharsUnix = new char[] { '/', '\0' };
+
         /// <summary>
         /// Converts bytes to megabytes.
         /// </summary>
@@ -40,8 +42,12 @@ internal static class IOManager
         public static string RemoveInvalidFileNameChars(string name)
         {
             StringBuilder fileBuilder = new(name);
-            foreach (char c in InvalidFileNameChars)
-                fileBuilder.Replace(c.ToString(), string.Empty);
+            if (RuntimeInformation.IsOSPlatform(OSPlatform.Windows))
+                foreach (char c in InvalidFileNameCharsWindows)
+                    fileBuilder.Replace(c.ToString(), string.Empty);
+            else if (RuntimeInformation.IsOSPlatform(OSPlatform.Linux) || RuntimeInformation.IsOSPlatform(OSPlatform.OSX))
+                foreach (char c in InvalidFileNameCharsUnix)
+                    fileBuilder.Replace(c.ToString(), string.Empty);
             return fileBuilder.ToString();
         }
 
@@ -58,24 +64,32 @@ public static string RemoveInvalidFileNameChars(string name)
         public static bool IsValidPath(string path) => TryGetFullPath(path, out _);
 
 
-        /// <summary>
-        /// Tries to get the absolute path for the specified path string.
-        /// </summary>
-        /// <param name="path">The file or directory for which to obtain absolute path information.</param>
-        /// <param name="result">
-        /// When this method returns, contains the absolute path representation of <paramref name="path"/>, 
-        /// if the conversion succeeded, or <see cref="string.Empty"/> if the conversion failed.
-        /// </param>
-        /// <returns>
-        /// <c>true</c> if <paramref name="path"/> was converted to an absolute path successfully; otherwise, <c>false</c>.
-        /// </returns>
         public static bool TryGetFullPath(string path, out string result)
         {
             result = string.Empty;
-            if (string.IsNullOrWhiteSpace(path) || path[1] != ':')
+
+            if (string.IsNullOrWhiteSpace(path))
                 return false;
-            bool status = false;
 
+            if (RuntimeInformation.IsOSPlatform(OSPlatform.Windows))
+            {
+                if (path.Length < 2 || path[1] != ':')
+                    return false;
+            }
+            else if (RuntimeInformation.IsOSPlatform(OSPlatform.Linux) || RuntimeInformation.IsOSPlatform(OSPlatform.OSX))
+            {
+                char[] invalidChars = Path.GetInvalidPathChars();
+                if (path.IndexOfAny(invalidChars) >= 0)
+                    return false;
+
+                if (Encoding.UTF8.GetByteCount(path) > 4096)
+                    return false;
+
+                if (!path.StartsWith("/") && !path.StartsWith("./") && !path.StartsWith("../"))
+                    return false;
+            }
+
+            bool status = false;
             try
             {
                 result = Path.GetFullPath(path);
@@ -97,9 +111,11 @@ public static bool TryGetFullPath(string path, out string result)
         /// <exception cref="SecurityException">Thrown when the caller does not have the required permission to perform this operation.</exception>
         public static string? GetHomePath()
         {
-            if (Environment.OSVersion.Platform == PlatformID.Unix)
+            if (RuntimeInformation.IsOSPlatform(OSPlatform.Windows))
+                return Environment.ExpandEnvironmentVariables("%HOMEDRIVE%%HOMEPATH%");
+            else if (RuntimeInformation.IsOSPlatform(OSPlatform.Linux) || RuntimeInformation.IsOSPlatform(OSPlatform.OSX))
                 return Environment.GetEnvironmentVariable("HOME");
-            return Environment.ExpandEnvironmentVariables("%HOMEDRIVE%%HOMEPATH%");
+            throw new PlatformNotSupportedException("The platform is not supported.");
         }
 
         /// <summary>
@@ -112,14 +128,7 @@ public static bool TryGetFullPath(string path, out string result)
         /// <exception cref="SecurityException">Thrown when the caller does not have the required permission to perform this operation.</exception>
         public static string? GetDownloadFolderPath()
         {
-            if (Environment.OSVersion.Platform == PlatformID.Unix)
-            {
-                string? homePath = GetHomePath();
-                if (string.IsNullOrEmpty(homePath))
-                    return null;
-                return Path.Combine(homePath, "Downloads");
-            }
-            else if (RuntimeInformation.IsOSPlatform(OSPlatform.Windows))
+            if (RuntimeInformation.IsOSPlatform(OSPlatform.Windows))
             {
                 string path = SHGetKnownFolderPath(new("374DE290-123F-4565-9164-39C4925E467B"), 0);
                 if (string.IsNullOrEmpty(path))
@@ -130,6 +139,13 @@ public static bool TryGetFullPath(string path, out string result)
                         , string.Empty));
                 else return path;
             }
+            else if (RuntimeInformation.IsOSPlatform(OSPlatform.Linux) || RuntimeInformation.IsOSPlatform(OSPlatform.OSX))
+            {
+                string? homePath = Environment.GetEnvironmentVariable("HOME");
+                if (string.IsNullOrEmpty(homePath))
+                    return null;
+                return Path.Combine(homePath, "Downloads");
+            }
             else return null;
         }