Skip to content

Commit 4154623

Browse files
author
Meyn
committed
Request Dispose Task not finished Fix
1 parent e64c46b commit 4154623

File tree

2 files changed

+3
-4
lines changed

2 files changed

+3
-4
lines changed

Requests/Request.cs

Lines changed: 2 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -191,7 +191,7 @@ public virtual void Dispose()
191191

192192
_cts?.Dispose();
193193
_ctr.Unregister();
194-
194+
_isFinished.TrySetCanceled();
195195
GC.SuppressFinalize(this);
196196
}
197197

@@ -274,7 +274,7 @@ private void EvalueateRequest(Request<TOptions, TCompleated, TFailed>.RequestRet
274274
/// <summary>
275275
/// Updates the Task's status based on the current state of the <see cref="Request{TOptions, TCompleated, TFailed}"/>.
276276
/// </summary>
277-
private void SetTaskState()
277+
protected void SetTaskState()
278278
{
279279
switch (State)
280280
{
@@ -287,7 +287,6 @@ private void SetTaskState()
287287
case RequestState.Cancelled:
288288
_isFinished.TrySetCanceled();
289289
break;
290-
291290
}
292291
}
293292

Requests/Requests.csproj

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -20,7 +20,7 @@
2020
<PackageRequireLicenseAcceptance>True</PackageRequireLicenseAcceptance>
2121
<PackageLicenseFile>LICENSE.txt</PackageLicenseFile>
2222
<PackageId>Shard.Requests</PackageId>
23-
<PackageReleaseNotes>Fix RequestContainer Array access</PackageReleaseNotes>
23+
<PackageReleaseNotes>Request Dispose Task not finished Fix</PackageReleaseNotes>
2424
</PropertyGroup>
2525

2626
<ItemGroup>

0 commit comments

Comments
 (0)