Implement EAC3 codec

Author: Meyn

Tubifarry/Core/Model/AudioMetadataHandler.cs

@@ -392,6 +392,16 @@ public bool TryEmbedMetadata(Album albumInfo, Track trackInfo)
                 file.Save();
                 return true;
             }
+            catch (TagLib.CorruptFileException ex)
+            {
+                _logger?.Error(ex, $"File is corrupted or has incorrect extension: {TrackPath}");
+                return false;
+            }
+            catch (TagLib.UnsupportedFormatException ex)
+            {
+                _logger?.Error(ex, $"File format does not support metadata embedding: {TrackPath}");
+                return false;
+            }
             catch (Exception ex)
             {
                 _logger?.Error(ex, $"Failed to embed metadata in track: {TrackPath}");
@@ -407,6 +417,25 @@ public bool TryEmbedMetadata(Album albumInfo, Track trackInfo)
         public static bool IsTargetFormatSupportedForEncoding(AudioFormat format) => BaseConversionParameters.ContainsKey(format);
 
 
+        ///// <summary>
+        ///// Checks if a given audio format supports embedded metadata tags.
+        ///// </summary>
+        ///// <param name="format">The audio format to check</param>
+        ///// <returns>True if the format supports metadata tagging, false otherwise</returns>
+        public static bool SupportsMetadataEmbedding(AudioFormat format) => format switch
+        {
+            // Formats that DO NOT support metadata embedding
+            AudioFormat.AC3 or AudioFormat.EAC3 or AudioFormat.MIDI => false,
+
+            // Formats that DO support metadata embedding
+            AudioFormat.AAC or AudioFormat.MP3 or AudioFormat.Opus or AudioFormat.Vorbis or
+            AudioFormat.FLAC or AudioFormat.WAV or AudioFormat.MP4 or AudioFormat.AIFF or
+            AudioFormat.OGG or AudioFormat.WMA or AudioFormat.ALAC or AudioFormat.APE => true,
+
+            // Unknown formats - assume they might support it
+            _ => true
+        };
+
         /// <summary>
         /// Gets the actual audio codec from a file using FFmpeg and returns the corresponding AudioFormat.
         /// </summary>

Tubifarry/Core/Utilities/AudioFormat.cs

@@ -18,7 +18,9 @@ public enum AudioFormat
         AMR,
         WMA,
         ALAC,
-        APE
+        APE,
+        AC3,
+        EAC3
     }
 
     internal static class AudioFormatHelper
@@ -30,7 +32,9 @@ internal static class AudioFormatHelper
             AudioFormat.Vorbis,
             AudioFormat.MP4,
             AudioFormat.AMR,
-            AudioFormat.WMA
+            AudioFormat.WMA,
+            AudioFormat.AC3,
+            AudioFormat.EAC3
         ];
 
         private static readonly int[] _standardBitrates = [
@@ -55,12 +59,14 @@ internal static class AudioFormatHelper
         {
             { AudioFormat.AAC,    (256, 64, 320) },
             { AudioFormat.MP3,    (320, 64, 320) },
-            { AudioFormat.Opus,   (96, 32, 510) },
+            { AudioFormat.Opus,   (256, 32, 510) },
             { AudioFormat.Vorbis, (224, 64, 500) },
             { AudioFormat.MP4,    (256, 64, 320) },
             { AudioFormat.AMR,    (12, 5, 12) },
             { AudioFormat.WMA,    (192, 48, 320) },
-            { AudioFormat.OGG,    (224, 64, 500) }
+            { AudioFormat.OGG,    (224, 64, 500) },
+            { AudioFormat.AC3,    (448, 192, 640) },
+            { AudioFormat.EAC3,   (768, 192, 6144) }
         };
 
         /// <summary>
@@ -91,6 +97,7 @@ internal static class AudioFormatHelper
             "opus" => ".opus",
             "flac" => ".flac",
             "ac3" => ".ac3",
+            "eac3" or "ec3" => ".ec3",
             "alac" => ".m4a",
             "vorbis" => ".ogg",
             "ape" => ".ape",
@@ -116,6 +123,8 @@ internal static class AudioFormatHelper
             "wma" => AudioFormat.WMA,
             "alac" => AudioFormat.ALAC,
             "ape" => AudioFormat.APE,
+            "ac3" or "ac-3" => AudioFormat.AC3,
+            "eac3" or "eac-3" or "e-ac-3" or "ec-3" or "ec3" => AudioFormat.EAC3,
             _ => AudioFormat.Unknown // Default for unknown formats
         };
 
@@ -138,6 +147,8 @@ internal static class AudioFormatHelper
             AudioFormat.OGG => ".ogg",
             AudioFormat.ALAC => ".m4a",
             AudioFormat.APE => ".ape",
+            AudioFormat.AC3 => ".ac3",
+            AudioFormat.EAC3 => ".ec3",
             _ => ".aac" // Default to AAC if the format is unknown
         };
 
@@ -176,6 +187,8 @@ internal static class AudioFormatHelper
             "wma" => AudioFormat.WMA,
             "alac" => AudioFormat.ALAC,
             "ape" => AudioFormat.APE,
+            "ac3" => AudioFormat.AC3,
+            "ec3" or "eac3" => AudioFormat.EAC3,
             _ => AudioFormat.Unknown
         };
 

Tubifarry/Download/Clients/SubSonic/SubSonicDownloadRequest.cs

@@ -306,6 +306,14 @@ private async Task<bool> PostProcessTrackAsync(SubSonicSearchSong trackInfo, Loa
             try
             {
                 AudioMetadataHandler audioData = new(trackPath) { AlbumCover = _albumCover };
+
+                AudioFormat detectedFormat = AudioFormatHelper.GetAudioCodecFromExtension(trackPath);
+                if (!AudioMetadataHandler.SupportsMetadataEmbedding(detectedFormat))
+                {
+                    _logger.Warn($"Skipping metadata embedding for {detectedFormat} format. Not supported: {Path.GetFileName(trackPath)}");
+                    return true;
+                }
+
                 Album album = CreateAlbumFromSubSonicData(trackInfo, _currentAlbum);
                 Track track = CreateTrackFromSubSonicData(trackInfo);