Implement UNIX support and adding ProtocolItem to DelayProfile if missing

Author: Meyn

.gitignore

@@ -363,3 +363,4 @@ MigrationBackup/
 FodyWeavers.xsd
 /_plugins/SpotiarrTube
 /_plugins/Tubifarry
+/enc_temp_folder/f7b6bdaa49df014838e55dd376c78df

README.md

@@ -1,55 +1,77 @@
 # Tubifarry for Lidarr 🎶  
 ![Downloads](https://img.shields.io/github/downloads/TypNull/Tubifarry/total)  ![GitHub release (latest by date)](https://img.shields.io/github/v/release/TypNull/Tubifarry)  ![GitHub last commit](https://img.shields.io/github/last-commit/TypNull/Tubifarry)  ![License](https://img.shields.io/github/license/TypNull/Tubifarry)  ![GitHub stars](https://img.shields.io/github/stars/TypNull/Tubifarry)  
 
-This plugin fetches metadata from **Spotify** and **YouTube** to download music directly from YouTube. It builds on the groundwork laid by trevTV's projects and utilizes the YouTube API for seamless integration. 🛠️  
+Tubifarry is a plugin for **Lidarr** that fetches metadata from **Spotify** and **YouTube**, enabling direct music downloads from YouTube. Built on the foundation of trevTV's projects, it leverages the YouTube API for smooth integration. 🛠️  
 
 ---
 
 ## Installation 🚀  
-To use Tubifarry, your Lidarr setup must be on the `plugins` branch. Below is a detailed guide to get started.  
+To use Tubifarry, ensure your Lidarr setup is on the `plugins` branch. Follow the steps below to get started.  
 
 ### Docker Setup (Hotio Image) 🐳  
-Here’s the Docker path for Hotio's image:  
+For Docker users using Hotio's image, use the following path:  
 ```yml  
     image: ghcr.io/hotio/lidarr:pr-plugins  
 ```  
 
+### Non-Docker Installation  
+To switch to the Plugins Branch:  
+1. Open Lidarr and navigate to `System -> General`.  
+2. Scroll down to the **Branch** section.  
+3. Replace "master" with "plugins".  
+4. Force an update check to update Lidarr to the plugins branch.  
+
 ---
 
 ### Prerequisites ⚙️  
-1. **FFmpeg**: FFmpeg is **required** for converting downloaded files to MP3 format. Ensure FFmpeg is installed and available on Windows system PATH or the specified ffmpeg path. If not, you can attempt to download it automatically during setup. Without FFmpeg, many songs fail to process correctly because they are downloaded as MP4 files, and TagLib cannot add metadata to MP4 formats.  
+1. **FFmpeg**: FFmpeg is **essential** for converting downloaded files to MP3 format. Ensure FFmpeg is installed and accessible in your system's PATH or the specified FFmpeg path. If not, you can attempt to download it automatically during setup. Without FFmpeg, many songs may fail to process correctly, as they are downloaded as MP4 files, and TagLib cannot add metadata to MP4 formats.  
+
+2. **Max Audio Quality**: Tubifarry supports a maximum audio quality of **256kb/s** for downloaded files. However, most files are in **MP3-VBR-V0** format.  
 
-2. **Max Audio Quality**: Tubifarry supports a maximum audio quality of **128 kb/s** for downloaded files. Ensure your settings align with this for optimal performance.  
+   **What is MP3-VBR-V0?**  
+   MP3-VBR-V0 is a high-quality audio format that uses **Variable Bitrate (VBR)** to optimize both sound quality and file size. Unlike a fixed bitrate (e.g., 128kb/s), VBR adjusts the bitrate dynamically based on the complexity of the audio. For example, it uses a higher bitrate for detailed parts of a song (like a chorus) and a lower bitrate for simpler parts (like silence). 
 
 ---
 
 ### Plugin Installation 📥  
+
+#### **For Docker Users**:  
 1. **Install the Plugin**:  
-   - In Lidarr, navigate to `System -> Plugins`.  
-   - Paste `https://github.com/TypNull/Tubifarry` into the GitHub URL box and press **Install**.  
+   - In Lidarr, go to `System -> Plugins`.  
+   - Paste `https://github.com/TypNull/Tubifarry` into the GitHub URL box and click **Install**.  
 
 2. **Configure the Indexer**:  
-   - Go to `Settings -> Indexers` and press **Add**.  
-   - In the modal, select `Tubifarry` (found under **Other** at the bottom).  
+   - Navigate to `Settings -> Indexers` and click **Add**.  
+   - In the modal, select `Tubifarry` (located under **Other** at the bottom).  
 
 3. **Set Up the Download Client**:  
-   - Go to `Settings -> Download Clients` and press **Add**.  
+   - Go to `Settings -> Download Clients` and click **Add**.  
    - In the modal, choose `Youtube` (under **Other** at the bottom).  
-   - Set the download path and adjust other settings to your preference.  
-
-4. **Enable Tubifarry in Delay Profiles**:  
-   - Go to `Settings -> Profiles -> Delay Profiles`.  
-   - For each profile, click the **wrench icon** on the right and enable Tubifarry.  
+   - Set the download path and adjust other settings as needed.  
+   - **Important**: Ensure the FFmpeg path is correctly configured!  
 
 ---
 
 ### Troubleshooting 🛠️  
-- **FFmpeg Issues**: If songs fail to process, ensure FFmpeg is correctly installed and accessible in your system's PATH. If not, try reinstalling or downloading it manually.  
-- **MP4 Metadata**: If metadata is not being added to downloaded files, verify that FFmpeg is converting files to MP3 format. MP4 files are not supported for metadata tagging by TagLib.  
+- **FFmpeg Issues**: If songs fail to process, verify that FFmpeg is correctly installed and accessible in your system's PATH. If not, try reinstalling or downloading it manually.  
+- **MP4 Metadata**: If metadata is not being added to downloaded files, confirm that FFmpeg is converting files to MP3 format (check debug logs). MP4 files are not supported for metadata tagging by TagLib.  
 - **Audio Quality**: Ensure the maximum audio quality is set to **128 kb/s** in your settings to avoid compatibility issues.  
 
 ---
 
 ## Acknowledgments 🙌  
-Special thanks to **trevTV** for the groundwork with [Lidarr.Plugin.Tidal](https://github.com/TrevTV/Lidarr.Plugin.Tidal), [Lidarr.Plugin.Deezer](https://github.com/TrevTV/Lidarr.Plugin.Deezer), and [Lidarr.Plugin.Qobuz](https://github.com/TrevTV/Lidarr.Plugin.Qobuz). Additionally, thanks to [IcySnex/YouTubeMusicAPI](https://github.com/IcySnex/YouTubeMusicAPI) for providing the YouTube API. 🎉  
+Special thanks to **trevTV** for laying the groundwork with [Lidarr.Plugin.Tidal](https://github.com/TrevTV/Lidarr.Plugin.Tidal), [Lidarr.Plugin.Deezer](https://github.com/TrevTV/Lidarr.Plugin.Deezer), and [Lidarr.Plugin.Qobuz](https://github.com/TrevTV/Lidarr.Plugin.Qobuz). Additionally, thanks to [IcySnex/YouTubeMusicAPI](https://github.com/IcySnex/YouTubeMusicAPI) for providing the YouTube API. 🎉  
+
+---
+
+## Contributing 🤝  
+If you'd like to contribute to Tubifarry, feel free to open issues or submit pull requests on the [GitHub repository](https://github.com/TypNull/Tubifarry). Your feedback and contributions are highly appreciated!  
+
+---
+
+## License 📄  
+Tubifarry is licensed under the MIT License. See the [LICENSE](https://github.com/TypNull/Tubifarry/blob/main/LICENSE) file for more details.  
+
+---
 
+Enjoy seamless music downloads with Tubifarry! 🎧

Tubifarry/Blocklisting/TubifarryBlocklist.cs

@@ -11,7 +11,7 @@ public class TubifarryBlocklist : IBlocklistForProtocol
 
         public TubifarryBlocklist(IBlocklistRepository blocklistRepository) => _blocklistRepository = blocklistRepository;
 
-        public string Protocol => nameof(TubifarryDownloadProtocol);
+        public string Protocol => nameof(YoutubeDownloadProtocol);
 
         public bool IsBlocklisted(int artistId, ReleaseInfo release) => _blocklistRepository.BlocklistedByTorrentInfoHash(artistId, release.Guid).Any(b => SameRelease(b, release));
 

Tubifarry/Core/AlbumData.cs

@@ -41,7 +41,7 @@ public ReleaseInfo ToReleaseInfo()
                 DownloadUrl = AlbumId,
                 InfoUrl = SpotifyUrl,
                 PublishDate = ReleaseDateTime,
-                DownloadProtocol = nameof(TubifarryDownloadProtocol),
+                DownloadProtocol = nameof(YoutubeDownloadProtocol),
                 Title = ConstructTitle(),
                 Codec = "MP3",
                 Resolution = CoverResolution,

Tubifarry/Download/Clients/YouTube/Youtube.cs

@@ -18,18 +18,16 @@ public class Youtube : DownloadClientBase<YoutubeProviderSettings>
 
         public Youtube(IYoutubeDownloadManager dlManager, IConfigService configService, IDiskProvider diskProvider, IRemotePathMappingService remotePathMappingService, Logger logger) : base(configService, diskProvider, remotePathMappingService, logger) => _dlManager = dlManager;
 
-
         public override string Name => "Youtube";
 
         public bool _tested = false;
 
-        public override string Protocol => nameof(TubifarryDownloadProtocol);
+        public override string Protocol => nameof(YoutubeDownloadProtocol);
 
         public new YoutubeProviderSettings Settings => base.Settings;
 
         public override Task<string> Download(RemoteAlbum remoteAlbum, IIndexer indexer) => _dlManager.Download(remoteAlbum, indexer, this);
 
-
         public override IEnumerable<DownloadClientItem> GetItems() => _dlManager.GetItems();
 
         public override void RemoveItem(DownloadClientItem item, bool deleteData)
@@ -77,9 +75,7 @@ public async Task TestFFmpeg(List<ValidationFailure> failures)
             }
 
             if (Settings.ReEncode == ReEncodeOptions.UseCustomFFmpeg && !AudioMetadataHandler.FFmpegIsInstalled)
-            {
                 failures.Add(new ValidationFailure("FFmpegPath", $"The specified FFmpeg path does not exist: {Settings.FFmpegPath}"));
-            }
         }
     }
 }

Tubifarry/Download/Clients/YouTube/YoutubeDownloadManager.cs

@@ -66,7 +66,6 @@ public Task<string> Download(RemoteAlbum remoteAlbum, IIndexer indexer, Youtube
 
         public IEnumerable<DownloadClientItem> GetItems() => _queue.Select(x => x.ClientItem);
 
-
         public void RemoveItem(DownloadClientItem item)
         {
             YouTubeAlbumRequest? req = _queue.ToList().Find(x => x.ID == item.DownloadId);

Tubifarry/Download/Clients/YouTube/YoutubeProviderSettings.cs

@@ -37,7 +37,7 @@ public class YoutubeProviderSettings : IProviderConfig
         public string DownloadPath { get; set; } = "";
 
         [FieldDefinition(1, Label = "Use LRCLIB Lyric Provider", HelpText = "Enable this option to fetch lyrics from LRCLIB.", Type = FieldType.Checkbox)]
-        public bool UseLRCLIB { get; set; } = true;
+        public bool UseLRCLIB { get; set; } = false;
 
         [FieldDefinition(2, Label = "Save Synced Lyrics", HelpText = "Enable this option to save synced lyrics to a separate .lrc file, if available. Requires .lrc to be allowed under Import Extra Files.", Type = FieldType.Checkbox)]
         public bool SaveSyncedLyrics { get; set; } = false;
@@ -49,10 +49,10 @@ public class YoutubeProviderSettings : IProviderConfig
         public int Chunks { get; set; } = 2;
 
         [FieldDefinition(5, Label = "ReEncode", Type = FieldType.Select, SelectOptions = typeof(ReEncodeOptions), HelpText = "Specify whether to re-encode audio files and how to handle FFmpeg.")]
-        public ReEncodeOptions ReEncode { get; set; } = ReEncodeOptions.Disabled;
+        public ReEncodeOptions ReEncode { get; set; } = ReEncodeOptions.UseFFmpegOrInstall;
 
-        [FieldDefinition(6, Label = "FFmpeg Path", Type = FieldType.Path, HelpText = "Specify the path to the FFmpeg binary. Required if 'Use Custom FFmpeg' is selected.", Advanced = true)]
-        public string FFmpegPath { get; set; } = "";
+        [FieldDefinition(6, Label = "FFmpeg Path", Type = FieldType.Path, Placeholder = "/downloads/FFmpeg", HelpText = "Specify the path to the FFmpeg binary. Not required if 'Disabled' is selected.", Advanced = false)]
+        public string FFmpegPath { get; set; } = string.Empty;
 
         public NzbDroneValidationResult Validate() => new(Validator.Validate(this));
     }

Tubifarry/Download/Clients/YouTubeAlbumRequest.cs

@@ -9,6 +9,7 @@
 using Requests.Options;
 using System.Text;
 using Tubifarry.Core;
+using YouTubeMusicAPI.Client;
 using YouTubeMusicAPI.Models;
 using YouTubeMusicAPI.Models.Info;
 using YouTubeMusicAPI.Models.Streaming;
@@ -31,7 +32,7 @@ internal class YouTubeAlbumRequest : Request<YouTubeAlbumOptions, string, string
         private readonly ReleaseInfo _releaseInfo;
         private readonly DownloadClientItem _clientItem;
 
-        private double _smoothedBytesPerSecond = 0;
+        private double _smoothedBytesPerSecond;
 
         private Logger? Logger => Options.Logger;
 
@@ -55,7 +56,7 @@ public DownloadClientItem ClientItem
 
         public YouTubeAlbumRequest(RemoteAlbum remoteAlbum, YouTubeAlbumOptions? options) : base(options)
         {
-            Options.YouTubeMusicClient ??= new();
+            Options.YouTubeMusicClient ??= new YouTubeMusicClient();
             _releaseInfo = remoteAlbum.Release;
             _requestContainer.Add(_trackContainer);
             _destinationPath = new(Path.Combine(Options.DownloadPath, _releaseInfo.Artist, _releaseInfo.Album));
@@ -71,8 +72,8 @@ private void ProcessAlbum()
                 AlbumInfo albumInfo = await Options.YouTubeMusicClient.GetAlbumInfoAsync(albumBrowseID, token);
                 if (albumInfo?.Songs == null || !albumInfo.Songs.Any())
                 {
-                    _message.AppendLine("No tracks to download found in the album.");
-                    Logger?.Debug("No tracks to download found in the album.");
+                    _message.AppendLine($"No tracks to download found in the album: {_releaseInfo.Album}.");
+                    Logger?.Debug($"No tracks to download found in the album: {_releaseInfo.Album}.");
                     return false;
                 }
 
@@ -198,7 +199,7 @@ private async Task<bool> SongDownloadCompletedAsync(AlbumInfo albumInfo, AlbumSo
             if (Options.TryIncludeSycLrc)
                 await audioData.TryCreateLrcFileAsync(token);
 
-            GetRemainingSize();
+            GetRemainingTime();
             return true;
         }
 
@@ -210,6 +211,7 @@ private async Task<bool> SongDownloadCompletedAsync(AlbumInfo albumInfo, AlbumSo
             DownloadClientInfo = Options.ClientInfo,
             OutputPath = _destinationPath,
         };
+
         private TimeSpan? GetRemainingTime()
         {
             long remainingSize = GetRemainingSize();

Tubifarry/Indexers/SpotiarrTubeDownloadProtocol.cs

@@ -1,4 +1,4 @@
 namespace NzbDrone.Core.Indexers
 {
-    public class TubifarryDownloadProtocol : IDownloadProtocol { }
+    public class YoutubeDownloadProtocol : IDownloadProtocol { }
 }

Tubifarry/Indexers/Spotify/Spotify.cs

@@ -9,7 +9,7 @@ namespace NzbDrone.Core.Indexers.Spotify
     internal class Spotify : HttpIndexerBase<SpotifyIndexerSettings>
     {
         public override string Name => "Tubifarry";
-        public override string Protocol => nameof(TubifarryDownloadProtocol);
+        public override string Protocol => nameof(YoutubeDownloadProtocol);
         public override bool SupportsRss => false;
         public override bool SupportsSearch => true;
         public override int PageSize => 50;