Enhance logging control in Modbus communication: adjust suppression logic based on debug level

Update version to 1.0.3 in manifest.json

Author: TypQxQ

custom_components/sigen/config_flow.py

@@ -383,7 +383,7 @@ async def async_dhcp_check_device_types(self, host, port=DEFAULT_PORT, timeout=1
         client = AsyncModbusTcpClient(host=host, port=port, timeout=timeout)
 
         try:
-            with _suppress_pymodbus_logging():
+            with _suppress_pymodbus_logging(really_suppress= False if _LOGGER.isEnabledFor(logging.DEBUG) else True):
                 if not await client.connect():
                     _LOGGER.debug("Modbus connection failed to %s:%s", host, port)
                     return False
@@ -582,7 +582,7 @@ async def _async_try_read_register(self, client: AsyncModbusTcpClient, slave_id:
             host = client.comm_params.host
             port = client.comm_params.port
 
-            with _suppress_pymodbus_logging():
+            with _suppress_pymodbus_logging(really_suppress= False if _LOGGER.isEnabledFor(logging.DEBUG) else True):
                 if not await client.connect():
                     err = ("Modbus connection failed to %s:%s" % (host, port))
                     _LOGGER.debug(err)
@@ -625,7 +625,7 @@ async def async_check_device_type(self, host, port, slave_id, timeout=1) -> str:
         client = AsyncModbusTcpClient(host=host, port=port, timeout=timeout)
 
         try:
-            with _suppress_pymodbus_logging():
+            with _suppress_pymodbus_logging(really_suppress= False if _LOGGER.isEnabledFor(logging.DEBUG) else True):
                 if not await client.connect():
                     _LOGGER.debug("Modbus connection failed to %s:%s", host, port)
                     return DEVICE_TYPE_UNKNOWN # Cannot determine type if connection fails

custom_components/sigen/manifest.json

@@ -21,5 +21,5 @@
   "loggers": ["custom_components.sigen"],
   "quality_scale": "custom",
   "requirements": ["pymodbus>=3.0.0"],
-  "version": "1.0.2"
+  "version": "1.0.3"
 }

custom_components/sigen/modbus.py

@@ -248,7 +248,7 @@ async def _probe_single_register(
     ) -> Tuple[str, bool, Optional[Exception]]:
         """Probe a single register and return its name, support status, and any exception."""
 
-        with _suppress_pymodbus_logging(really_suppress=True):
+        with _suppress_pymodbus_logging(really_suppress= False if _LOGGER.isEnabledFor(logging.DEBUG) else True):
             if register.register_type == RegisterType.READ_ONLY:
                 result = await client.read_input_registers(
                     address=register.address,
@@ -401,7 +401,7 @@ async def async_read_registers(
             key = self._get_connection_key(device_info)
 
             async with self._locks[key]:
-                with _suppress_pymodbus_logging():
+                with _suppress_pymodbus_logging(really_suppress= False if _LOGGER.isEnabledFor(logging.DEBUG) else True):
                     result = await client.read_input_registers(
                         address=address, count=count, slave=slave_id
                     ) if register_type == RegisterType.READ_ONLY \