test: use latest version of tiptap with changes for transaction handling

Author: nperez0111

package.json

@@ -59,10 +59,5 @@
     "start": "serve playground/dist -c ../serve.json",
     "test": "nx run-many --target=test",
     "format": "prettier --write \"**/*.{js,jsx,ts,tsx,css,scss,md}\""
-  },
-  "overrides": {
-    "@tiptap/core": "^3.0.0",
-    "@tiptap/pm": "^3.0.0",
-    "@tiptap/react": "^3.0.0"
   }
 }

packages/core/src/api/positionMapping.test.ts

@@ -19,6 +19,21 @@ describe("PositionStorage with local editor", () => {
 
       editor._tiptapEditor.destroy();
     });
+
+    it("should register transaction handler on creation & mount", () => {
+      const editor = BlockNoteEditor.create();
+      // editor.mount(document.createElement("div"));
+
+      editor._tiptapEditor.on = vi.fn();
+      trackPosition(editor, 0);
+
+      expect(editor._tiptapEditor.on).toHaveBeenCalledWith(
+        "transaction",
+        expect.any(Function),
+      );
+
+      editor._tiptapEditor.destroy();
+    });
   });
 
   describe("set and get positions", () => {
@@ -89,6 +104,49 @@ describe("PositionStorage with local editor", () => {
     editor._tiptapEditor.destroy();
   });
 
+  it("should update mapping for local transactions before the position (unmounted)", () => {
+    const editor = BlockNoteEditor.create();
+
+    // Set initial content
+    editor.insertBlocks(
+      [
+        {
+          id: "1",
+          type: "paragraph",
+          content: [
+            {
+              type: "text",
+              text: "Hello World",
+              styles: {},
+            },
+          ],
+        },
+      ],
+      editor.document[0],
+      "before",
+    );
+
+    // Start tracking
+    const getPos = trackPosition(editor, 10);
+
+    // Move the cursor to the start of the document
+    editor.setTextCursorPosition(editor.document[0], "start");
+
+    // Insert text at the start of the document
+    editor.insertInlineContent([
+      {
+        type: "text",
+        text: "Test",
+        styles: {},
+      },
+    ]);
+
+    // Position should be updated according to mapping
+    expect(getPos()).toBe(14);
+
+    editor._tiptapEditor.destroy();
+  });
+
   it("should not update mapping for local transactions after the position", () => {
     const editor = BlockNoteEditor.create();
     editor.mount(document.createElement("div"));

packages/core/src/api/positionMapping.ts

@@ -61,9 +61,7 @@ export function trackPosition(
    */
   side: "left" | "right" = "left",
 ): () => number {
-  const ySyncPluginState = ySyncPluginKey.getState(
-    editor._tiptapEditor.state,
-  ) as {
+  const ySyncPluginState = ySyncPluginKey.getState(editor.prosemirrorState) as {
     doc: Y.Doc;
     binding: ProsemirrorBinding;
   };
@@ -95,7 +93,7 @@ export function trackPosition(
 
   return () => {
     const curYSyncPluginState = ySyncPluginKey.getState(
-      editor._tiptapEditor.state,
+      editor.prosemirrorState,
     ) as typeof ySyncPluginState;
     const pos = relativePositionToAbsolutePosition(
       curYSyncPluginState.doc,

packages/xl-ai/src/testUtil/cases/combinedOperationsTestCases.ts

@@ -1,4 +1,5 @@
 // import { BlockNoteEditor, getBlockInfo, getNodeById } from "@blocknote/core";
+import { getBlockInfo, getNodeById } from "@blocknote/core";
 import { getEditorWithFormattingAndMentions } from "./editors/formattingAndMentions.js";
 import { DocumentOperationTestCase } from "./index.js";
 
@@ -22,39 +23,39 @@ export const combinedOperationsTestCases: DocumentOperationTestCase[] = [
     userPrompt:
       "add a new paragraph with the text 'You look great today!' after the first paragraph and translate 'Hello, world' to dutch",
   },
-  // {
-  //   editor: getEditorWithFormattingAndMentions,
-  //   description: "add paragraph and update selection",
-  //   // Note: this test is important because it will validate whether the
-  //   // positions of `getTestSelection` are mapped correctly after the first toolcall
-  //   baseToolCalls: [
-  //     {
-  //       type: "add",
-  //       blocks: [{ content: "You look great today!" }],
-  //       referenceId: "ref2",
-  //       position: "before",
-  //     },
-  //     {
-  //       type: "update",
-  //       id: "ref2",
-  //       block: {
-  //         content: [{ type: "text", text: "Hallo", styles: {} }],
-  //       },
-  //     },
-  //   ],
-  //   getTestSelection: (editor: BlockNoteEditor<any, any, any>) => {
-  //     const posInfo = getNodeById("ref2", editor.prosemirrorState.doc)!;
+  {
+    editor: getEditorWithFormattingAndMentions,
+    description: "add paragraph and update selection",
+    // Note: this test is important because it will validate whether the
+    // positions of `getTestSelection` are mapped correctly after the first toolcall
+    baseToolCalls: [
+      {
+        type: "add",
+        blocks: [{ content: "You look great today!" }],
+        referenceId: "ref2",
+        position: "before",
+      },
+      {
+        type: "update",
+        id: "ref2",
+        block: {
+          content: [{ type: "text", text: "Hallo", styles: {} }],
+        },
+      },
+    ],
+    getTestSelection: (editor) => {
+      const posInfo = getNodeById("ref2", editor.prosemirrorState.doc)!;
 
-  //     const block = getBlockInfo(posInfo);
-  //     if (!block.isBlockContainer) {
-  //       throw new Error("Block is not a block container");
-  //     }
-  //     return {
-  //       from: block.blockContent.beforePos + 1,
-  //       to: block.blockContent.beforePos + 1 + "Hello".length,
-  //     };
-  //   },
-  //   userPrompt:
-  //     "add a paragraph with the text 'You look great today!' at the beginning and translate selection to German",
-  // },
+      const block = getBlockInfo(posInfo);
+      if (!block.isBlockContainer) {
+        throw new Error("Block is not a block container");
+      }
+      return {
+        from: block.blockContent.beforePos + 1,
+        to: block.blockContent.beforePos + 1 + "Hello".length,
+      };
+    },
+    userPrompt:
+      "add a paragraph with the text 'You look great today!' at the beginning and translate selection to German",
+  },
 ];