Fixed suggestion menu crash

matthewlipski · matthewlipski · commit 1407e0b4799a · 2025-05-16T16:51:57.000+02:00
diff --git a/packages/core/src/i18n/locales/ar.ts b/packages/core/src/i18n/locales/ar.ts
@@ -163,7 +163,6 @@ export const ar: Dictionary = {
   },
   suggestion_menu: {
     no_items_title: "لم يتم العثور على عناصر",
-    loading: "جارٍ التحميل…",
   },
   color_picker: {
     text_title: "نص",
diff --git a/packages/core/src/i18n/locales/de.ts b/packages/core/src/i18n/locales/de.ts
@@ -178,7 +178,6 @@ export const de: Dictionary = {
   },
   suggestion_menu: {
     no_items_title: "Keine Elemente gefunden",
-    loading: "Laden …",
   },
   color_picker: {
     text_title: "Text",
diff --git a/packages/core/src/i18n/locales/en.ts b/packages/core/src/i18n/locales/en.ts
@@ -178,7 +178,6 @@ export const en = {
   },
   suggestion_menu: {
     no_items_title: "No items found",
-    loading: "Loading…",
   },
   color_picker: {
     text_title: "Text",
diff --git a/packages/core/src/i18n/locales/es.ts b/packages/core/src/i18n/locales/es.ts
@@ -177,7 +177,6 @@ export const es: Dictionary = {
   },
   suggestion_menu: {
     no_items_title: "No se encontraron elementos",
-    loading: "Cargando…",
   },
   color_picker: {
     text_title: "Texto",
diff --git a/packages/core/src/i18n/locales/fr.ts b/packages/core/src/i18n/locales/fr.ts
@@ -202,7 +202,6 @@ export const fr: Dictionary = {
   },
   suggestion_menu: {
     no_items_title: "Aucun élément trouvé",
-    loading: "Chargement…",
   },
   color_picker: {
     text_title: "Texte",
diff --git a/packages/core/src/i18n/locales/hr.ts b/packages/core/src/i18n/locales/hr.ts
@@ -191,7 +191,6 @@ export const hr: Dictionary = {
   },
   suggestion_menu: {
     no_items_title: "Stavke nisu pronađene",
-    loading: "Učitavanje…",
   },
   color_picker: {
     text_title: "Tekst",
diff --git a/packages/core/src/i18n/locales/is.ts b/packages/core/src/i18n/locales/is.ts
@@ -170,7 +170,6 @@ export const is: Dictionary = {
   },
   suggestion_menu: {
     no_items_title: "Engir hlutir fundust",
-    loading: "Hleður…",
   },
   color_picker: {
     text_title: "Texti",
diff --git a/packages/core/src/i18n/locales/it.ts b/packages/core/src/i18n/locales/it.ts
@@ -179,7 +179,6 @@ export const it: Dictionary = {
   },
   suggestion_menu: {
     no_items_title: "Nessun elemento trovato",
-    loading: "Caricamento…",
   },
   color_picker: {
     text_title: "Testo",
diff --git a/packages/core/src/i18n/locales/ja.ts b/packages/core/src/i18n/locales/ja.ts
@@ -198,7 +198,6 @@ export const ja: Dictionary = {
   },
   suggestion_menu: {
     no_items_title: "アイテムが見つかりません",
-    loading: "読込中…",
   },
   color_picker: {
     text_title: "文字色",
diff --git a/packages/core/src/i18n/locales/ko.ts b/packages/core/src/i18n/locales/ko.ts
@@ -191,7 +191,6 @@ export const ko: Dictionary = {
   },
   suggestion_menu: {
     no_items_title: "항목을 찾을 수 없음",
-    loading: "로딩 중…",
   },
   color_picker: {
     text_title: "텍스트",
diff --git a/packages/core/src/i18n/locales/nl.ts b/packages/core/src/i18n/locales/nl.ts
@@ -178,7 +178,6 @@ export const nl: Dictionary = {
   },
   suggestion_menu: {
     no_items_title: "Geen items gevonden",
-    loading: "Laden…",
   },
   color_picker: {
     text_title: "Tekst",
diff --git a/packages/core/src/i18n/locales/no.ts b/packages/core/src/i18n/locales/no.ts
@@ -178,7 +178,6 @@ export const no: Dictionary = {
   },
   suggestion_menu: {
     no_items_title: "Ingen elementer funnet",
-    loading: "Laster…",
   },
   color_picker: {
     text_title: "Tekst",
diff --git a/packages/core/src/i18n/locales/pl.ts b/packages/core/src/i18n/locales/pl.ts
@@ -162,7 +162,6 @@ export const pl: Dictionary = {
   },
   suggestion_menu: {
     no_items_title: "Nie znaleziono elementów",
-    loading: "Ładowanie…",
   },
   color_picker: {
     text_title: "Tekst",
diff --git a/packages/core/src/i18n/locales/pt.ts b/packages/core/src/i18n/locales/pt.ts
@@ -170,7 +170,6 @@ export const pt: Dictionary = {
   },
   suggestion_menu: {
     no_items_title: "Nenhum item encontrado",
-    loading: "Carregando…",
   },
   color_picker: {
     text_title: "Texto",
diff --git a/packages/core/src/i18n/locales/ru.ts b/packages/core/src/i18n/locales/ru.ts
@@ -205,7 +205,6 @@ export const ru: Dictionary = {
   },
   suggestion_menu: {
     no_items_title: "ничего не найдено",
-    loading: "Загрузка…",
   },
   color_picker: {
     text_title: "Текст",
diff --git a/packages/core/src/i18n/locales/sk.ts b/packages/core/src/i18n/locales/sk.ts
@@ -177,7 +177,6 @@ export const sk = {
   },
   suggestion_menu: {
     no_items_title: "Nenašli sa žiadne položky",
-    loading: "Načítava sa…",
   },
   color_picker: {
     text_title: "Text",
diff --git a/packages/core/src/i18n/locales/uk.ts b/packages/core/src/i18n/locales/uk.ts
@@ -203,7 +203,6 @@ export const uk: Dictionary = {
   },
   suggestion_menu: {
     no_items_title: "Нічого не знайдено",
-    loading: "Завантаження…",
   },
   color_picker: {
     text_title: "Текст",
diff --git a/packages/core/src/i18n/locales/vi.ts b/packages/core/src/i18n/locales/vi.ts
@@ -177,7 +177,6 @@ export const vi: Dictionary = {
   },
   suggestion_menu: {
     no_items_title: "Không tìm thấy mục nào",
-    loading: "Đang tải...",
   },
   color_picker: {
     text_title: "Văn bản",
diff --git a/packages/core/src/i18n/locales/zh-tw.ts b/packages/core/src/i18n/locales/zh-tw.ts
@@ -211,7 +211,6 @@ export const zhTW: Dictionary = {
   },
   suggestion_menu: {
     no_items_title: "無相符項目",
-    loading: "載入中…",
   },
   color_picker: {
     text_title: "文字",
diff --git a/packages/core/src/i18n/locales/zh.ts b/packages/core/src/i18n/locales/zh.ts
@@ -211,7 +211,6 @@ export const zh: Dictionary = {
   },
   suggestion_menu: {
     no_items_title: "无匹配项",
-    loading: "加载中…",
   },
   color_picker: {
     text_title: "文本",
diff --git a/packages/react/src/components/SuggestionMenu/GridSuggestionMenu/GridSuggestionMenu.tsx b/packages/react/src/components/SuggestionMenu/GridSuggestionMenu/GridSuggestionMenu.tsx
@@ -20,9 +20,7 @@ export function GridSuggestionMenu<T extends DefaultReactGridSuggestionItem>(
       <Components.GridSuggestionMenu.Loader
         className={"bn-grid-suggestion-menu-loader"}
         columns={columns}
-      >
-        {dict.suggestion_menu.loading}
-      </Components.GridSuggestionMenu.Loader>
+      />
     ) : null;
 
   const renderedItems = useMemo<JSX.Element[]>(() => {
diff --git a/packages/react/src/components/SuggestionMenu/SuggestionMenu.tsx b/packages/react/src/components/SuggestionMenu/SuggestionMenu.tsx
@@ -14,9 +14,9 @@ export function SuggestionMenu<T extends DefaultReactSuggestionItem>(
 
   const loader =
     loadingState === "loading-initial" || loadingState === "loading" ? (
-      <Components.SuggestionMenu.Loader className={"bn-suggestion-menu-loader"}>
-        {dict.suggestion_menu.loading}
-      </Components.SuggestionMenu.Loader>
+      <Components.SuggestionMenu.Loader
+        className={"bn-suggestion-menu-loader"}
+      />
     ) : null;
 
   const renderedItems = useMemo<JSX.Element[]>(() => {
