Fixed setSelection position (#484)

matthewlipski · web-flow · commit 36d17aaa0a24 · 2023-12-22T15:48:30.000+01:00
diff --git a/packages/core/src/extensions/SideMenu/SideMenuPlugin.ts b/packages/core/src/extensions/SideMenu/SideMenuPlugin.ts
@@ -547,7 +547,7 @@ export class SideMenuView<
       return;
     }
 
-    const { contentNode, endPos } = blockInfo;
+    const { contentNode, startPos, endPos } = blockInfo;
 
     // Creates a new block if current one is not empty for the suggestion menu to open in.
     if (contentNode.textContent.length !== 0) {
@@ -561,7 +561,7 @@ export class SideMenuView<
         .setTextSelection(newBlockContentPos)
         .run();
     } else {
-      this.editor._tiptapEditor.commands.setTextSelection(endPos);
+      this.editor._tiptapEditor.commands.setTextSelection(startPos + 1);
     }
 
     // Focuses and activates the suggestion menu.

Original file line number	Diff line number	Diff line change
`@@ -547,7 +547,7 @@ export class SideMenuView<`
`547`	`547`	`return;`
`548`	`548`	`}`
`549`	`549`
`550`		`- const { contentNode, endPos } = blockInfo;`
	`550`	`+ const { contentNode, startPos, endPos } = blockInfo;`
`551`	`551`
`552`	`552`	`// Creates a new block if current one is not empty for the suggestion menu to open in.`
`553`	`553`	`if (contentNode.textContent.length !== 0) {`
`@@ -561,7 +561,7 @@ export class SideMenuView<`
`561`	`561`	`.setTextSelection(newBlockContentPos)`
`562`	`562`	`.run();`
`563`	`563`	`} else {`
`564`		`- this.editor._tiptapEditor.commands.setTextSelection(endPos);`
	`564`	`+ this.editor._tiptapEditor.commands.setTextSelection(startPos + 1);`
`565`	`565`	`}`
`566`	`566`
`567`	`567`	`// Focuses and activates the suggestion menu.`