Skip to content

Commit 5d6385b

Browse files
authored
fix: parentElement did not work (#127)
1 parent 7e26cb5 commit 5d6385b

File tree

1 file changed

+21
-17
lines changed

1 file changed

+21
-17
lines changed

packages/core/src/BlockNoteEditor.ts

Lines changed: 21 additions & 17 deletions
Original file line numberDiff line numberDiff line change
@@ -1,34 +1,34 @@
11
import { Editor, EditorOptions } from "@tiptap/core";
22
import { Node } from "prosemirror-model";
33
// import "./blocknote.css";
4-
import {
5-
Block,
6-
BlockIdentifier,
7-
PartialBlock,
8-
} from "./extensions/Blocks/api/blockTypes";
9-
import { getBlockNoteExtensions, UiFactories } from "./BlockNoteExtensions";
10-
import styles from "./editor.module.css";
11-
import {
12-
defaultSlashMenuItems,
13-
BaseSlashMenuItem,
14-
} from "./extensions/SlashMenu";
154
import { Editor as TiptapEditor } from "@tiptap/core/dist/packages/core/src/Editor";
16-
import { nodeToBlock } from "./api/nodeConversions/nodeConversions";
17-
import { TextCursorPosition } from "./extensions/Blocks/api/cursorPositionTypes";
18-
import { getBlockInfoFromPos } from "./extensions/Blocks/helpers/getBlockInfoFromPos";
19-
import { getNodeById } from "./api/util/nodeUtil";
205
import {
216
insertBlocks,
22-
updateBlock,
237
removeBlocks,
248
replaceBlocks,
9+
updateBlock,
2510
} from "./api/blockManipulation/blockManipulation";
2611
import {
2712
blocksToHTML,
28-
HTMLToBlocks,
2913
blocksToMarkdown,
14+
HTMLToBlocks,
3015
markdownToBlocks,
3116
} from "./api/formatConversions/formatConversions";
17+
import { nodeToBlock } from "./api/nodeConversions/nodeConversions";
18+
import { getNodeById } from "./api/util/nodeUtil";
19+
import { getBlockNoteExtensions, UiFactories } from "./BlockNoteExtensions";
20+
import styles from "./editor.module.css";
21+
import {
22+
Block,
23+
BlockIdentifier,
24+
PartialBlock,
25+
} from "./extensions/Blocks/api/blockTypes";
26+
import { TextCursorPosition } from "./extensions/Blocks/api/cursorPositionTypes";
27+
import { getBlockInfoFromPos } from "./extensions/Blocks/helpers/getBlockInfoFromPos";
28+
import {
29+
BaseSlashMenuItem,
30+
defaultSlashMenuItems,
31+
} from "./extensions/SlashMenu";
3232

3333
export type BlockNoteEditorOptions = {
3434
// TODO: Figure out if enableBlockNoteExtensions/disableHistoryExtension are needed and document them.
@@ -99,6 +99,10 @@ export class BlockNoteEditor {
9999
},
100100
};
101101

102+
if (options.parentElement) {
103+
tiptapOptions.element = options.parentElement;
104+
}
105+
102106
this._tiptapEditor = new Editor(tiptapOptions) as Editor & {
103107
contentComponent: any;
104108
};

0 commit comments

Comments
 (0)